-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to reduce flakiness in RandomStringSourceTests #1921
Attempt to reduce flakiness in RandomStringSourceTests #1921
Conversation
…ility. Split tests into two. JUnit 5. Signed-off-by: David Venable <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1921-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d641f767fa4e75d9d7cfdc0ac88a336c81f30a1
# Push it to GitHub
git push --set-upstream origin backport/backport-1921-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5 1.5
# Navigate to the new working tree
cd .worktrees/backport-1.5
# Create a new branch
git switch --create backport/backport-1921-to-1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d641f767fa4e75d9d7cfdc0ac88a336c81f30a1
# Push it to GitHub
git push --set-upstream origin backport/backport-1921-to-1.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5 Then, create a pull request where the |
…ility. Split tests into two. JUnit 5. (#1921) Signed-off-by: David Venable <[email protected]> (cherry picked from commit 3d641f7)
…ility. Split tests into two. JUnit 5. (#1921) (#1964) Signed-off-by: David Venable <[email protected]> (cherry picked from commit 3d641f7) Co-authored-by: David Venable <[email protected]>
Description
I've seen the
RandomStringSourceTests
fail a few times in GitHub Actions. I updated the test to use Awaitility rather than a simple sleep and increased the maximum time.While I was here, I noticed the test is testing two things, so I split it. And I updated to JUnit 5.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.