Jackson to 2.16.1 #4134
Merged
Jackson to 2.16.1 #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… redact input data in exceptions. So a couple tests needed modifications. Additionally, this uses ion-java 1.10.5 which has a fix for CVE-2024-21634, so this PR will resolve opensearch-project#3926. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
| @@ -75,7 +75,6 @@ void constructor_throws_if_schema_is_invalid() { | |||
| RuntimeException actualException = assertThrows(RuntimeException.class, this::createObjectUnderTest); | |||
|
|
|||
| assertThat(actualException.getMessage(), notNullValue()); | |||
| assertThat(actualException.getMessage(), containsString(invalidSchema)); | |||
There was a problem hiding this comment.
Why did we remove this assertion?
There was a problem hiding this comment.
I gave a very brief explanation in the description. Prior to Jackson 2.16, Jackson would include input data in the messages provided. Now it does not do that (by default) to avoid possible log injection or display of sensitive data. So this exception fails now as the input schema is no longer in the message.
asifsmohammed
approved these changes
Feb 22, 2024
oeyh
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Jackson to 2.16.1. Jackson 2.16 now redacts input data in exceptions. So a couple tests needed modifications.
Additionally, this uses ion-java 1.10.5 which has a fix for CVE-2024-21634.
Issues Resolved
Resolves #3926
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.