Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transient test failure for subpipelines #4479

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

srikanthjg
Copy link
Collaborator

@srikanthjg srikanthjg commented Apr 30, 2024

Description

  • Fixed transient test failures for pipeline configuration transformation.
  • Fixed null handling.

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

return false;
} catch(IOException e){
throw new RuntimeException(e);
}finally {
Copy link
Member

@dinujoh dinujoh Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @srikanthjg !

@dlvenable dlvenable merged commit ebfc1df into opensearch-project:main Apr 30, 2024
41 of 47 checks passed
@srikanthjg srikanthjg deleted the transformationfix branch May 7, 2024 04:22
@kkondaka kkondaka added this to the v2.8 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants