Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins for new plugin framework #451

Merged

Conversation

dlvenable
Copy link
Member

Description

This commit updates existing plugins to use the new pluginType property rather than the deprecated type.

Issues Resolved

Resolves #322.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…taPrepperPlugin annotation. Resolves #322.

Signed-off-by: David Venable <[email protected]>
@dlvenable dlvenable changed the title Updated existing plugins to use the new pluginType property in the Da… Update plugins for new plugin framework Oct 20, 2021
Copy link
Contributor

@laneholloway laneholloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that method I've commented on is transitional, please note it as such. If not, I'll change to approved.

Copy link
Contributor

@laneholloway laneholloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, github changes missed the @Deprecated that was added in last PR.

Copy link
Contributor

@sshivanii sshivanii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlvenable dlvenable merged commit c7b0e39 into opensearch-project:main Oct 20, 2021
@dlvenable dlvenable deleted the plugin-annotation-update-322 branch October 20, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Class Refactoring
3 participants