NPE bug fixes in the DefaultLogstashPluginAttributesMapper #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l values. Part of opensearch-project#568. Signed-off-by: David Venable <[email protected]>
jianghancn
reviewed
Nov 12, 2021
|
|
||
| final Map<String, Object> pluginSettings = new LinkedHashMap<>(); | ||
|
|
||
| if(logstashAttributesMappings.getAdditionalAttributes() != null) { |
There was a problem hiding this comment.
Would it be feasible and nicer to have logstashAttributesMappings.getAdditionalAttributes() already return a non-null value? If it returns an empty map in this case, it would be great.
There was a problem hiding this comment.
Yea, I'd like that.
The underlying cause is that the model is being deserialized from YAML. So, we will need to make the model return an empty list instead of null when it is not set. But, this should be possible.
asifsmohammed
previously approved these changes
Nov 12, 2021
…sent in the YAML. opensearch-project#568 Signed-off-by: David Venable <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
=========================================
Coverage 92.28% 92.29%
Complexity 569 569
=========================================
Files 71 71
Lines 1725 1727 +2
Branches 144 144
=========================================
+ Hits 1592 1594 +2
Misses 102 102
Partials 31 31
Continue to review full report at Codecov.
|
jianghancn
approved these changes
Nov 12, 2021
5 tasks
chenqi0805
added a commit
to chenqi0805/data-prepper
that referenced
this pull request
Nov 12, 2021
* main: Fixes the main branch from a renaming that happened when two related PRs were merged around the same time. (opensearch-project#583) Grpc Basic auth for Otel trace Source (opensearch-project#570) Fixed a NullPointerException which LogstashVisitor was throwing for attributes without a value. (opensearch-project#582) Update PipelineModel to fix serialization (opensearch-project#577) Log analytics getting started (opensearch-project#573) Support maps which are not present in the YAML, which Jackson appears to be treating differently from explicit nulls. opensearch-project#568 (opensearch-project#579) Add support for codeowners to repo (opensearch-project#578) Added logstash mapper which maps logstash configuration to pipeline m… (opensearch-project#575) Document OpenSearch Sink configuration parameters number_of_shards and number_of_replicas. (opensearch-project#562) Added instructions to build and run the Docker image locally. (opensearch-project#564) NPE bug fixes in the DefaultLogstashPluginAttributesMapper (opensearch-project#574) switch Path.of to Paths.get (opensearch-project#566) Fix PrepperState javadoc (opensearch-project#567) Signed-off-by: qchea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrected some null issues from the refactoring.
Issues Resolved
Part of #568
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.