Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opensearch output plugin to converter #754

Closed

Conversation

asifsmohammed
Copy link
Collaborator

@asifsmohammed asifsmohammed commented Dec 16, 2021

Signed-off-by: Asif Sohail Mohammed [email protected]

Description

  • Added OpenSearch output plugin mapping file
  • Added an expression in mapping file to support negation of boolean Logstash attribute values

Issues Resolved

Resolves #746
Resolves #710

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@asifsmohammed asifsmohammed requested a review from a team as a code owner December 16, 2021 19:01
@codecov-commenter
Copy link

Codecov Report

Merging #754 (7b0af33) into main (cb00d69) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #754      +/-   ##
============================================
+ Coverage     91.54%   91.70%   +0.16%     
  Complexity      627      627              
============================================
  Files            75       75              
  Lines          1844     1844              
  Branches        158      158              
============================================
+ Hits           1688     1691       +3     
+ Misses          120      117       -3     
  Partials         36       36              
Impacted Files Coverage Δ
...java/com/amazon/dataprepper/pipeline/Pipeline.java 92.85% <0.00%> (+4.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb00d69...7b0af33. Read the comment docs.

@asifsmohammed
Copy link
Collaborator Author

I'll create separate PR's for both the issues addressed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants