[2.x] Adding new stop-replication action in ism #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#1368) * Add release notes for v2.19 * Added release notes for v2.19.0 * Added Release Notes for v2.19.0 --------- (cherry picked from commit eb6afa8) Signed-off-by: Vaibhav Agarwal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: aggarwalShivani <[email protected]>
aggarwalShivani
requested review from
bowenlan-amzn,
Hailong-am,
vikasvb90,
tandonks,
shiv0408 and
soosinha
as code owners
1 task
* Increment version to 2.19.1-SNAPSHOT Signed-off-by: opensearch-ci-bot <[email protected]> * Update glibc solution Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: opensearch-ci-bot <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
|
@aggarwalShivani seems current stable branch is 2.19, can you click update branch button once for this PR. |
| @@ -313,6 +319,7 @@ def jobSchedulerFile = resolvePluginFile("opensearch-job-scheduler") | |||
| def notificationsCoreFile = resolvePluginFile("opensearch-notifications-core") | |||
| def notificationsFile = resolvePluginFile("notifications") | |||
| def securityPluginFile = resolvePluginFile("opensearch-security") | |||
| def ccrFile = resolvePluginFile("opensearch-security") | |||
There was a problem hiding this comment.
Suggested change
| def ccrFile = resolvePluginFile("opensearch-security") | |
| def ccrFile = resolvePluginFile("opensearch-cross-cluster-replication") |
Comment on lines
+71
to
+73
| ccr_build_download = 'https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/' + opensearch_no_snapshot + | ||
| '/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-cross-cluster-replication-' + ccr_no_snapshot + '.zip' | ||
| ccr_resource_folder = "src/test/resources/replication" |
There was a problem hiding this comment.
Suggested change
| ccr_build_download = 'https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/' + opensearch_no_snapshot + | |
| '/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-cross-cluster-replication-' + ccr_no_snapshot + '.zip' | |
| ccr_resource_folder = "src/test/resources/replication" |
| @@ -35,6 +35,7 @@ buildscript { | |||
| job_scheduler_no_snapshot = opensearch_build | |||
| notifications_no_snapshot = opensearch_build | |||
| security_no_snapshot = opensearch_build | |||
| ccr_no_snapshot = opensearch_build | |||
There was a problem hiding this comment.
Suggested change
| ccr_no_snapshot = opensearch_build |
Comment on lines
+40
to
+45
| val replicationPluginInterface: ReplicationPluginInterface = mock() | ||
| whenever(replicationPluginInterface.stopReplication(any(), any(), any())) | ||
| .thenAnswer { invocation -> | ||
| val listener = invocation.getArgument<ActionListener<AcknowledgedResponse>>(2) | ||
| listener.onResponse(stopReplicationResponse) // Simulate a successful response | ||
| } |
There was a problem hiding this comment.
If you have time, can you try mock the client instead. Though there's another layer ReplicationPluginInterface in between, in the end, we still make the call using client so I hope it can work.
So we don't need to have that setter for ReplicationPluginInterface in the source code
There was a problem hiding this comment.
Seems you already tried #1198 (comment)
Let me try once then
There was a problem hiding this comment.
@aggarwalShivani please check this commit bowenlan-amzn@81c5626
There was a problem hiding this comment.
Thank you so much @bowenlan-amzn, this helps a lot 😃
I've tried the UTs this way and it works. I will verify thoroughly with these changes and push in the next commit.
| waitFor { | ||
| val metadataInfo = getExplainManagedIndexMetaData(indexName).info.toString() | ||
| assertTrue( | ||
| metadataInfo.contains("cause=No replication in progress for index:" + indexName), |
There was a problem hiding this comment.
Is this a failure? Can we also assert sth like step status is failed
There was a problem hiding this comment.
Yes thats right, we're testing the negative case here.
Sure, i'll add the step status check too. Thanks!
|
Successfully run locally, here's the related log Details |
Signed-off-by: aggarwalShivani <[email protected]>
Hi @bowenlan-amzn I'm not sure why, it shows this file release-notes/opensearch-index-management.release-notes-2.19.1.0.md in my committed files, but i dont see this file in 2.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1198 on 2.x branch. Pls see the PR on main branch for complete background.
Mainly, the changes are ->
Related Issues
Resolves #726
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.