Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish shadow jar instead of regular one. #779

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Publish shadow jar instead of regular one. #779

merged 1 commit into from
Mar 2, 2023

Conversation

Yury-Fridlyand
Copy link
Contributor

Description

Continue work done in #764 - workaround for #778.
Having ml-plugin is not enough to build SQL plugin, it requires ml-common too. Having both together produces jar hell described in #778.
As a workaround I propose publishing a shadow jar.

Issues Resolved

Related to #778, #764, #763, #754, #755

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand Yury-Fridlyand requested a review from a team March 2, 2023 22:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #779 (f1028a9) into main (6e178d2) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #779      +/-   ##
============================================
+ Coverage     84.05%   84.06%   +0.01%     
- Complexity     1012     1037      +25     
============================================
  Files            93       99       +6     
  Lines          3662     3740      +78     
  Branches        342      344       +2     
============================================
+ Hits           3078     3144      +66     
- Misses          438      448      +10     
- Partials        146      148       +2     
Flag Coverage Δ
ml-commons 84.06% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 98.82% <0.00%> (-1.18%) ⬇️
.../java/org/opensearch/ml/task/MLTaskDispatcher.java 32.94% <0.00%> (-0.80%) ⬇️
...main/java/org/opensearch/ml/utils/MLNodeUtils.java 94.44% <0.00%> (ø)
...n/java/org/opensearch/ml/model/MLModelManager.java 78.20% <0.00%> (ø)
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <0.00%> (ø)
.../org/opensearch/ml/breaker/DiskCircuitBreaker.java 36.36% <0.00%> (ø)
...rg/opensearch/ml/breaker/MemoryCircuitBreaker.java 100.00% <0.00%> (ø)
...opensearch/ml/breaker/ThresholdCircuitBreaker.java 100.00% <0.00%> (ø)
...opensearch/ml/breaker/MLCircuitBreakerService.java 100.00% <0.00%> (ø)
...nsearch/ml/breaker/NativeMemoryCircuitBreaker.java 84.61% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn ylwu-amzn merged commit b735d3f into opensearch-project:main Mar 2, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the maven-publish-all-jars-#763 branch March 2, 2023 23:33
@Yury-Fridlyand
Copy link
Contributor Author

Awesome, we can compile SQL plugin now. Thanks!

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
. (#779)

Signed-off-by: Yury-Fridlyand <[email protected]>
(cherry picked from commit b735d3f)
ylwu-amzn pushed a commit that referenced this pull request Mar 6, 2023
. (#779) (#785)

Signed-off-by: Yury-Fridlyand <[email protected]>
(cherry picked from commit b735d3f)

Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants