-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish shadow jar instead of regular one. #779
Publish shadow jar instead of regular one. #779
Conversation
. Signed-off-by: Yury-Fridlyand <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #779 +/- ##
============================================
+ Coverage 84.05% 84.06% +0.01%
- Complexity 1012 1037 +25
============================================
Files 93 99 +6
Lines 3662 3740 +78
Branches 342 344 +2
============================================
+ Hits 3078 3144 +66
- Misses 438 448 +10
- Partials 146 148 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Awesome, we can compile SQL plugin now. Thanks! |
. (#779) Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit b735d3f)
. (#779) (#785) Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit b735d3f) Co-authored-by: Yury-Fridlyand <[email protected]>
Description
Continue work done in #764 - workaround for #778.
Having
ml-plugin
is not enough to build SQL plugin, it requiresml-common
too. Having both together produces jar hell described in #778.As a workaround I propose publishing a shadow jar.
Issues Resolved
Related to #778, #764, #763, #754, #755
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.