Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix guava jar hell issue #1536

Merged
merged 1 commit into from
May 18, 2023
Merged

fix guava jar hell issue #1536

merged 1 commit into from
May 18, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented May 18, 2023

Description

Fix Jar hell issue in 2.8 artifact

Issues Resolved

Fix First part of #1535

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@pjfitzgibbons pjfitzgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the overall effect of this change? How does this change the calculated dependecy tree? How does this walk towards fixing #1535 ?

@derek-ho
Copy link
Collaborator Author

What's the overall effect of this change? How does this change the calculated dependecy tree? How does this walk towards fixing #1535 ?

Build will be failing until we merge this in, maybe my message was incorrect, but this fix needs to go in regardless

@derek-ho derek-ho merged commit 4a9b754 into opensearch-project:2.x May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants