add dashboards functional test repo into build process

[tianleh]

Description

As part of the ongoing effort to support dashboards functional tests, #604, we want to add this repo https://github.com/opensearch-project/opensearch-dashboards-functional-test into the build process. Note that this repo contains only test cases and is not a regular dashboards plugin. Thus we only have an empty build script for it.

Issues Resolved

#783

Test

[opensearch@fdf06b8e8974 opensearch-build]$ ./build.sh manifests/1.1.0/opensearch-dashboards-1.1.0.yml --component functionalTestDashboards
Installing dependencies in . ...
Installing dependencies from Pipfile.lock (22bd6c)...
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/0 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
Running ./src/run_build.py manifests/1.1.0/opensearch-dashboards-1.1.0.yml --component functionalTestDashboards ...
2021-10-22 02:24:15 INFO     Building in /tmp/tmpcr5f96td
2021-10-22 02:24:15 INFO     Building OpenSearch Dashboards (x64) into /usr/share/opensearch/opensearch-build/artifacts
2021-10-22 02:24:15 INFO     Skipping OpenSearch-Dashboards
2021-10-22 02:24:15 INFO     Skipping alertingDashboards
2021-10-22 02:24:15 INFO     Skipping queryWorkbenchDashboards
2021-10-22 02:24:15 INFO     Skipping securityDashboards
2021-10-22 02:24:15 INFO     Skipping indexManagementDashboards
2021-10-22 02:24:15 INFO     Skipping anomalyDetectionDashboards
2021-10-22 02:24:15 INFO     Skipping reportsDashboards
2021-10-22 02:24:15 INFO     Skipping notebooksDashboards
2021-10-22 02:24:15 INFO     Skipping traceAnalyticsDashboards
2021-10-22 02:24:15 INFO     Skipping ganttChartDashboards
2021-10-22 02:24:15 INFO     Building functionalTestDashboards
2021-10-22 02:24:15 INFO     Executing "git init" in /tmp/tmpcr5f96td/functionalTestDashboards
2021-10-22 02:24:15 INFO     Executing "git remote add origin https://github.com/opensearch-project/opensearch-dashboards-functional-test.git" in /tmp/tmpcr5f96td/functionalTestDashboards
2021-10-22 02:24:15 INFO     Executing "git fetch --depth 1 origin main" in /tmp/tmpcr5f96td/functionalTestDashboards
2021-10-22 02:24:18 INFO     Executing "git checkout FETCH_HEAD" in /tmp/tmpcr5f96td/functionalTestDashboards
2021-10-22 02:24:18 INFO     Executing "git rev-parse HEAD" in /tmp/tmpcr5f96td/functionalTestDashboards
2021-10-22 02:24:18 INFO     Checked out https://github.com/opensearch-project/opensearch-dashboards-functional-test.git@main into /tmp/tmpcr5f96td/functionalTestDashboards at 16caeb7d21e0295d3ebbf4a3fcc83ba37b81d86e
2021-10-22 02:24:18 INFO     Executing "bash /usr/share/opensearch/opensearch-build/scripts/components/functionalTestDashboards/build.sh -v 1.1.0 -p linux -a x64 -s false -o artifacts" in /tmp/tmpcr5f96td/functionalTestDashboards
2021-10-22 02:24:18 INFO     Created build manifest /usr/share/opensearch/opensearch-build/artifacts/manifest.yml
2021-10-22 02:24:18 INFO     Done.

Verified that manifest yml

build:
  architecture: x64
  id: c11e460896214ede86a5b14597479713
  name: OpenSearch Dashboards
  platform: linux
  version: 1.1.0
components:
- artifacts: {}
  commit_id: 16caeb7d21e0295d3ebbf4a3fcc83ba37b81d86e
  name: functionalTestDashboards
  ref: main
  repository: https://github.com/opensearch-project/opensearch-dashboards-functional-test.git
  version: 1.1.0.0
schema-version: '1.2'

Check List

• [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

Can you please revert Pipfile.lock? That atomicwrites change is needed on Windows, but it's a Windows-only dependency. I added it explicitly in #786

[peternied]

Why add the tests into the build/bundle process? My concern is that it could add unrelated dependencies to the release build.

Since these tests are in separate repo it it might be easier to add a stage during test execution to pull them in.

If we did want to build test at the same time, I'd recommend updating the manifest schema to treat them distinctly.

[peternied]

Can you please revert Pipfile.lock? That atomicwrites change is needed on Windows, but it's a Windows-only dependency. I added it explicitly in #786

We might need an updated ci check and way to make sure that platform specific dependencies are not getting axed accidentally

[dblock]

Can you please revert Pipfile.lock? That atomicwrites change is needed on Windows, but it's a Windows-only dependency. I added it explicitly in #786

We might need an updated ci check and way to make sure that platform specific dependencies are not getting axed accidentally

Good point, we just need to run tests if Pipfile or Pipfile.lock have changed. I updated #786

[tianleh]

Can you please revert Pipfile.lock? That atomicwrites change is needed on Windows, but it's a Windows-only dependency. I added it explicitly in #786

Thanks for calling out. Reverted.