Generate majority of indices operations #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
feat/code-gen/indices-2
branch
from
a985cd2 to
a979a81
Compare
reta
reviewed
Dec 20, 2024
| generator.writeKey("time"); | ||
| generator.write(this.time); | ||
|
|
||
| generator.writeKey("getTime"); |
There was a problem hiding this comment.
The getTime does not look right. shouldn't be time?:
Suggested change
| generator.writeKey("getTime"); | |
| generator.writeKey("time"); |
There was a problem hiding this comment.
The field is actually getTime: https://github.com/opensearch-project/OpenSearch/blob/2.x/server/src/main/java/org/opensearch/index/get/GetStats.java#L158
Looks like this bug was introduced nearly twelve years ago: opensearch-project/OpenSearch@cc83c2f#diff-f7abcc8f5eb3ec75bb9be11b7fe88baa0bcedf62c3c481552a0e98ceb7125a27R124
There was a problem hiding this comment.
Do you mind creating an issue on OpenSearch side?
There was a problem hiding this comment.
reta
approved these changes
Dec 20, 2024
Xtansia
added a commit
to Xtansia/opensearch-java
that referenced
this pull request
Feb 18, 2025
* Generate indices.clone Signed-off-by: Thomas Farr <[email protected]> * Generate indices.close Signed-off-by: Thomas Farr <[email protected]> * Generate indices.flush Signed-off-by: Thomas Farr <[email protected]> * Generate indices.forcemerge Signed-off-by: Thomas Farr <[email protected]> * Generate indices.get_upgrade Signed-off-by: Thomas Farr <[email protected]> * Generate indices.open Signed-off-by: Thomas Farr <[email protected]> * Generate indices.recovery Signed-off-by: Thomas Farr <[email protected]> * Generate indices.refresh Signed-off-by: Thomas Farr <[email protected]> * Generate indices.resolve_index Signed-off-by: Thomas Farr <[email protected]> * Generate indices.rollover Signed-off-by: Thomas Farr <[email protected]> * Generate indices.segments Signed-off-by: Thomas Farr <[email protected]> * Generate indices.shard_stores Signed-off-by: Thomas Farr <[email protected]> * Generate indices.shrink Signed-off-by: Thomas Farr <[email protected]> * Generate indices.split Signed-off-by: Thomas Farr <[email protected]> * Generate indices.stats Signed-off-by: Thomas Farr <[email protected]> * Remove deserializing of path params Signed-off-by: Thomas Farr <[email protected]> * Generate indices.upgrade Signed-off-by: Thomas Farr <[email protected]> * Generate indices.validate_query Signed-off-by: Thomas Farr <[email protected]> * Simplify operation filtering Signed-off-by: Thomas Farr <[email protected]> * RemoteStoreUploadStats.pressure as optional Signed-off-by: Thomas Farr <[email protected]> * Handle segment replication stats returning strings in some versions Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 9f9ea7c)
Xtansia
added a commit
that referenced
this pull request
Feb 21, 2025
* Generate toBuilder and Builder.copy methods (#1300) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit fea4138) * Generate IndexSettings (#1295) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit bd171fb) * Fix Signed-off-by: Thomas Farr <[email protected]> * Generate query DSL types (#1337) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 75ff633) * Generate more indices operations (#1342) * Generate indices.delete_template Signed-off-by: Thomas Farr <[email protected]> * Generate indices.exists_template Signed-off-by: Thomas Farr <[email protected]> * Generate indices.put_template and indices.simulate_template Signed-off-by: Thomas Farr <[email protected]> * Generate indices.get_settings Signed-off-by: Thomas Farr <[email protected]> * Generate indices.put_settings Signed-off-by: Thomas Farr <[email protected]> * Generate indices.get_mapping and indices.put_mapping Signed-off-by: Thomas Farr <[email protected]> * Adjust matching Signed-off-by: Thomas Farr <[email protected]> * Fix Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 6a5b947) * Generate DataStream operations (#1351) * Generate DataStream operations Signed-off-by: Thomas Farr <[email protected]> * Fix tests Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit b07eae5) * Generate remaining snapshot requests (#1357) * Generate snapshot repository requests Signed-off-by: Thomas Farr <[email protected]> * Generate remaining snapshot requests Signed-off-by: Thomas Farr <[email protected]> * Rename restore request Signed-off-by: Thomas Farr <[email protected]> * Disambiguate class names Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 354debe) * Generate more indices operations (#1358) * Generate aliases operations Signed-off-by: Thomas Farr <[email protected]> * Generate indices.add_block Signed-off-by: Thomas Farr <[email protected]> * Generate indices.analyze Signed-off-by: Thomas Farr <[email protected]> * Generate indices.clear_cache Signed-off-by: Thomas Farr <[email protected]> * Remove deserializing of path params in request objects Signed-off-by: Thomas Farr <[email protected]> * Test that deserialization fails Signed-off-by: Thomas Farr <[email protected]> * spotless Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 773b200) * Generate majority of indices operations (#1360) * Generate indices.clone Signed-off-by: Thomas Farr <[email protected]> * Generate indices.close Signed-off-by: Thomas Farr <[email protected]> * Generate indices.flush Signed-off-by: Thomas Farr <[email protected]> * Generate indices.forcemerge Signed-off-by: Thomas Farr <[email protected]> * Generate indices.get_upgrade Signed-off-by: Thomas Farr <[email protected]> * Generate indices.open Signed-off-by: Thomas Farr <[email protected]> * Generate indices.recovery Signed-off-by: Thomas Farr <[email protected]> * Generate indices.refresh Signed-off-by: Thomas Farr <[email protected]> * Generate indices.resolve_index Signed-off-by: Thomas Farr <[email protected]> * Generate indices.rollover Signed-off-by: Thomas Farr <[email protected]> * Generate indices.segments Signed-off-by: Thomas Farr <[email protected]> * Generate indices.shard_stores Signed-off-by: Thomas Farr <[email protected]> * Generate indices.shrink Signed-off-by: Thomas Farr <[email protected]> * Generate indices.split Signed-off-by: Thomas Farr <[email protected]> * Generate indices.stats Signed-off-by: Thomas Farr <[email protected]> * Remove deserializing of path params Signed-off-by: Thomas Farr <[email protected]> * Generate indices.upgrade Signed-off-by: Thomas Farr <[email protected]> * Generate indices.validate_query Signed-off-by: Thomas Farr <[email protected]> * Simplify operation filtering Signed-off-by: Thomas Farr <[email protected]> * RemoteStoreUploadStats.pressure as optional Signed-off-by: Thomas Farr <[email protected]> * Handle segment replication stats returning strings in some versions Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 9f9ea7c) * Re-generate client code using latest OpenSearch API specification (2024-12-23) (#1364) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 8896d26) * Generate cluster namespace (#1365) * Generate cluster.allocation_explain Signed-off-by: Thomas Farr <[email protected]> * Generate component_template operations Signed-off-by: Thomas Farr <[email protected]> * Generate cluster settings operations Signed-off-by: Thomas Farr <[email protected]> * Generate voting_config_exclusions operations Signed-off-by: Thomas Farr <[email protected]> * Generate cluster.health Signed-off-by: Thomas Farr <[email protected]> * Generate cluster.pending_tasks Signed-off-by: Thomas Farr <[email protected]> * Generate cluster.remote_info Signed-off-by: Thomas Farr <[email protected]> * Generate cluster.reroute Signed-off-by: Thomas Farr <[email protected]> * Generate cluster.state Signed-off-by: Thomas Farr <[email protected]> * Generate cluster.stats Signed-off-by: Thomas Farr <[email protected]> * Fix build Signed-off-by: Thomas Farr <[email protected]> * Fix compile Signed-off-by: Thomas Farr <[email protected]> * Fix spotless Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit be6b6d8) * Re-generate client code using latest OpenSearch API specification (2024-12-30) (#1371) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 0a8d8cd) * Generate nodes namespace (#1372) * Generate nodes.info Signed-off-by: Thomas Farr <[email protected]> * Generate nodes.reload_secure_settings Signed-off-by: Thomas Farr <[email protected]> * Generate nodes.stats Signed-off-by: Thomas Farr <[email protected]> * Fix build Signed-off-by: Thomas Farr <[email protected]> * Generate nodes.usage Signed-off-by: Thomas Farr <[email protected]> * Simplify operation filtering Signed-off-by: Thomas Farr <[email protected]> * Extra node info fields Signed-off-by: Thomas Farr <[email protected]> * Fix tests Signed-off-by: Thomas Farr <[email protected]> * Fix tests Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 4cbb17f) * Generate ingest namespace (#1375) * Generate ingest.delete_pipeline Signed-off-by: Thomas Farr <[email protected]> * Remove ingest.geo_ip_stats Signed-off-by: Thomas Farr <[email protected]> * Generate ingest.get_pipeline Signed-off-by: Thomas Farr <[email protected]> * Generate ingest.processor_grok Signed-off-by: Thomas Farr <[email protected]> * Generate ingest.put_pipeline Signed-off-by: Thomas Farr <[email protected]> * Generate ingest.simulate Signed-off-by: Thomas Farr <[email protected]> * Simplify filtering Signed-off-by: Thomas Farr <[email protected]> * Fix build Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit bd77f0d) * Generate cat namespace (#1376) * Generate cat.aliases and refactor CatRequestBase and RequestBase Signed-off-by: Thomas Farr <[email protected]> * Generate cat.allocation Signed-off-by: Thomas Farr <[email protected]> * Generate cat.cluster_manager & cat.master Signed-off-by: Thomas Farr <[email protected]> * Generate cat.count Signed-off-by: Thomas Farr <[email protected]> * Generate cat.fielddata Signed-off-by: Thomas Farr <[email protected]> * Generate cat.health Signed-off-by: Thomas Farr <[email protected]> * Generate cat.indices Signed-off-by: Thomas Farr <[email protected]> * Generate cat.nodeattrs Signed-off-by: Thomas Farr <[email protected]> * Generate cat.nodes Signed-off-by: Thomas Farr <[email protected]> * Generate cat.all_pit_segments, cat.pending_tasks, cat.pit_segments & cat.plugins Signed-off-by: Thomas Farr <[email protected]> * Generate cat.recovery, cat.repositories & cat.segments Signed-off-by: Thomas Farr <[email protected]> * Generate cat.shards, cat.snapshots & cat.tasks Signed-off-by: Thomas Farr <[email protected]> * Generate cat.templates & cat.thread_pool Signed-off-by: Thomas Farr <[email protected]> * Generate cat.segment_replication Signed-off-by: Thomas Farr <[email protected]> * Fix build Signed-off-by: Thomas Farr <[email protected]> * Fix tests Signed-off-by: Thomas Farr <[email protected]> * Fix test Signed-off-by: Thomas Farr <[email protected]> * spotless Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 1aa832a) * Generate part of core namespace (#1377) * Generate clear_score and ignore paths/operations that have been deprecated since OS 1.0 Signed-off-by: Thomas Farr <[email protected]> * Generate count Signed-off-by: Thomas Farr <[email protected]> * Generate create_pit Signed-off-by: Thomas Farr <[email protected]> * Generate delete Signed-off-by: Thomas Farr <[email protected]> * Generate delete_all_pits & delete_pit Signed-off-by: Thomas Farr <[email protected]> * Generate delete_by_query, reindex & update_by_query Signed-off-by: Thomas Farr <[email protected]> * Generate delete_by_query_rethrottle, reindex_rethrottle, update_by_query_rethrottle Signed-off-by: Thomas Farr <[email protected]> * Generate get_all_pits Signed-off-by: Thomas Farr <[email protected]> * Generate delete_script, get_script, get_script_context, get_script_languages & put_script Signed-off-by: Thomas Farr <[email protected]> * Generate exists & exists_source Signed-off-by: Thomas Farr <[email protected]> * Generate field_caps Signed-off-by: Thomas Farr <[email protected]> * Generate mtermvectors Signed-off-by: Thomas Farr <[email protected]> * Generate ping Signed-off-by: Thomas Farr <[email protected]> * Generate rank_eval Signed-off-by: Thomas Farr <[email protected]> * Generate render_search_template Signed-off-by: Thomas Farr <[email protected]> * Generate search_shards Signed-off-by: Thomas Farr <[email protected]> * Remove terms_enum Signed-off-by: Thomas Farr <[email protected]> * Fix build Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit dffa9c9) * Generate ml operations (#1389) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit b84ec6c) * Generate aggregation types (#1392) * Generating Signed-off-by: Thomas Farr <[email protected]> * Re-generate Signed-off-by: Thomas Farr <[email protected]> * Generating 2 Signed-off-by: Thomas Farr <[email protected]> * Generating 3 Signed-off-by: Thomas Farr <[email protected]> * Generating 4 Signed-off-by: Thomas Farr <[email protected]> * Fix build Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 786e58d) * Generate remaining query DSL types (#1415) * Generating Signed-off-by: Thomas Farr <[email protected]> * Generating Signed-off-by: Thomas Farr <[email protected]> * Generating Signed-off-by: Thomas Farr <[email protected]> * Generating Signed-off-by: Thomas Farr <[email protected]> * Fixes Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 8069c3c) * Generate additional search request related structures (#1438) * Generate Suggester types Signed-off-by: Thomas Farr <[email protected]> * Generate additional search request related structures Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit cb56241) * Changelog Signed-off-by: Thomas Farr <[email protected]> * Undo breaking changes in CatRequestBase Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generates all but one indices operation that requires some extra work/handling that will be done separately.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.