trust_env to the aiohttp.ClientSession #372
Conversation
Temirlan-qa
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
|
Please sign DCO (amend the commit with |
|
It was already done in this pull request #370 |
Signed-off-by: saimedhi <[email protected]> Signed-off-by: Temirlan-qa <[email protected]>
Signed-off-by: bl1nkker <[email protected]> Signed-off-by: Temirlan-qa <[email protected]>
Signed-off-by: Temirlan-qa <[email protected]>
Signed-off-by: Temirlan-qa <[email protected]>
Signed-off-by: Temirlan-qa <[email protected]>
Signed-off-by: Temirlan-qa <[email protected]>
Signed-off-by: Temirlan-qa <[email protected]>
| uses: codecov/codecov-action@v2 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: ./junit/opensearch-py-codecov.xml |
There was a problem hiding this comment.
These changes here seem unrelated. Make a separate PR to fix codecov?
| @@ -5,6 +5,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Added | |||
| - Added async support for helpers that are merged from opensearch-dsl-py ([#329](https://github.com/opensearch-project/opensearch-py/pull/329)) | |||
| ### Changed | |||
| - Upgrading pytest-asyncio to latest version - 0.21.0 ([#339](https://github.com/opensearch-project/opensearch-py/pull/339)) | |||
| @@ -97,6 +97,27 @@ def test_opaque_id(self): | |||
| con = AIOHttpConnection(opaque_id="app-1") | |||
| assert con.headers["x-opaque-id"] == "app-1" | |||
|
|
|||
| def test_trust_env(self): | |||
There was a problem hiding this comment.
Add a test for defaults if we don't have one yet, test_async_opensearch_default_options, and one that changes all the options test_async_opensearch_options.
| assert con.session.connector.trust_env | ||
|
|
||
| async def test_async_opensearch_trust_env(self): | ||
| # Create an instance of AsyncOpenSearch with trust_env set to True |
There was a problem hiding this comment.
To be nitpicky, the comments are incorrect, because the test actually sets other options too, which they don't mention.
I think they are simply unnecessary as the test and the code is self-explanatory. Would just remove to avoid being out of sync with the code.
| test-linux: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ['2.7', '3.7', '3.8', '3.9', '3.10', '3.11'] | ||
| python-version: ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"] |
There was a problem hiding this comment.
I think these changes are unrelated.
|
Hello, @Temirlan-qa. Please fix the CI tests that are failing. If you have too many merge conflicts, you can also close this pull request and create a PR on a new branch that is in sync with the upstream source. Include only the changes that are relevant to the issue. |
|
Hello @Temirlan-qa, Closing this pull request as it appears to be merged in PR #438 |
Description
Passed
trust_env=Trueto theaiohttp.ClientSessionIssues Resolved
closes #368
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.