-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS display-none
utility
#1120
Conversation
Signed-off-by: Shahriar Shatil <[email protected]>
Signed-off-by: Shahriar Shatil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShatilKhan Can you also update https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/utility_classes/utility_classes.js so that the new class is listed on https://oui.opensearch.org/1.3/#/utilities/css-utility-classes
Yeah I'll update it today |
@ShatilKhan Just checking back to see if you'll be able to finish up this PR. |
Yeah @joshuarrrr |
Signed-off-by: Shahriar Shatil <[email protected]>
Done with this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ShatilKhan! Just a few minor formatting tweaks.
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]>
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]>
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]>
Done with the suggested changes |
Signed-off-by: Shahriar Shatil <[email protected]>
This linting error should be fixed: https://github.com/opensearch-project/oui/actions/runs/7175077016/job/19539863193?pr=1120#step:5:17 |
Signed-off-by: Shahriar Shatil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed linting problem on line 104 in utility_classes.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized this should also be added to src/themes/oui-next/global_styling/utility/_utility.scss
so it works in next themes as well
Signed-off-by: Shahriar Shatil <[email protected]>
done |
* Update _utility.scss Signed-off-by: Shahriar Shatil <[email protected]> * Update CHANGELOG.md Signed-off-by: Shahriar Shatil <[email protected]> * Add `oui-displayNone` to `utility_classes.js` Signed-off-by: Shahriar Shatil <[email protected]> * Update utility_classes.js Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]> * Fix typo in utility_classes.js Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]> * Fix Indentation in utility_classes.js Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]> * fix lint Signed-off-by: Shahriar Shatil <[email protected]> * Add displayNone to oui-next Signed-off-by: Shahriar Shatil <[email protected]> --------- Signed-off-by: Shahriar Shatil <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 5e7ac43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* Update _utility.scss Signed-off-by: Shahriar Shatil <[email protected]> * Update CHANGELOG.md Signed-off-by: Shahriar Shatil <[email protected]> * Add `oui-displayNone` to `utility_classes.js` Signed-off-by: Shahriar Shatil <[email protected]> * Update utility_classes.js Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]> * Fix typo in utility_classes.js Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]> * Fix Indentation in utility_classes.js Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]> * fix lint Signed-off-by: Shahriar Shatil <[email protected]> * Add displayNone to oui-next Signed-off-by: Shahriar Shatil <[email protected]> --------- Signed-off-by: Shahriar Shatil <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 5e7ac43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Added new CSS Utility Class
display-none
Issues Resolved
Fixes #773
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.