Fix:Query-Insights-Dashboards-style-integration-QueryDetails #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishoreKicha14
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
|
Please run cypress tests, linting and unit tests locally before submitting PR if possible. @KishoreKicha14 Cypress tests can be run using: Applicable for all 3 PRs |
KishoreKicha14
force-pushed
the
Fix-Query-Insights-Dashboards-Trineo-style-integration-QueryDetails
branch
2 times, most recently
from
1e8e0ce to
c06fc4f
Compare
KishoreKicha14
changed the title
|
Could you update the screenshot in the PR to reflect the latest change? Right now the screenshot just says: "the feature is not working". |
KishoreKicha14
force-pushed
the
Fix-Query-Insights-Dashboards-Trineo-style-integration-QueryDetails
branch
from
58f57cc to
0eb3b73
Compare
KishoreKicha14
force-pushed
the
Fix-Query-Insights-Dashboards-Trineo-style-integration-QueryDetails
branch
from
2d1f027 to
8a3ea37
Compare
KishoreKicha14
force-pushed
the
Fix-Query-Insights-Dashboards-Trineo-style-integration-QueryDetails
branch
from
8a3ea37 to
0eb3b73
Compare
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
added 2 commits
February 14, 2025 01:08
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
ansjcy
approved these changes
Feb 14, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Query Details Styling Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * update the test file Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * update the test file lint Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 8e586d0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Query Details Styling Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * update the test file Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * update the test file lint Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 8e586d0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Feb 14, 2025
ansjcy
pushed a commit
that referenced
this pull request
Feb 14, 2025
) * Query Details Styling * update the test file * update the test file lint --------- (cherry picked from commit 8e586d0) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
ansjcy
pushed a commit
that referenced
this pull request
Feb 14, 2025
) * Query Details Styling * update the test file * update the test file lint --------- (cherry picked from commit 8e586d0) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
64 tasks
KishoreKicha14
added a commit
to KishoreKicha14/query-insights-dashboards
that referenced
this pull request
Feb 28, 2025
…rch-project#69) * Query Details Styling Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * update the test file Signed-off-by: Kishore Kumaar Natarajan <[email protected]> * update the test file lint Signed-off-by: Kishore Kumaar Natarajan <[email protected]> --------- Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryDetails Page UI Refinements
Description
This update introduces UI refinements to the
QueryDetailspage, focusing on improving consistency, accessibility, and overall layout. Key changes include:size="s"to align with the global design system.UI Adjustments
size="s"for a streamlined appearance.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.