Add description for VectorDBTool and remove json parsing for RAGTool #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
yuye-aws
reviewed
Jan 11, 2024
rbhavna
approved these changes
Jan 12, 2024
|
I see some test failure |
|
@ylwu-amzn can you please help rerunning the test? I don't see error in local build |
sure, reran it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
============================================
- Coverage 81.23% 80.82% -0.42%
Complexity 193 193
============================================
Files 13 13
Lines 975 975
Branches 130 130
============================================
- Hits 792 788 -4
- Misses 133 137 +4
Partials 50 50 ☔ View full report in Codecov by Sentry. |
ylwu-amzn
approved these changes
Jan 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
…121) Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit c81746e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rbhavna
pushed a commit
that referenced
this pull request
Jan 26, 2024
…121) (#124) (cherry picked from commit c81746e) Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…pensearch-project#121) (opensearch-project#124) (cherry picked from commit c81746e) Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add description for VectorDBTool and remove json parsing for RAGTool
To avoid special characters in parsing the questions from users, removing the json parsing to allow more flexibilities from users' questions.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.