-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune AD and alerting tool descriptions #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=========================================
Coverage 81.73% 81.73%
Complexity 196 196
=========================================
Files 13 13
Lines 1002 1002
Branches 132 132
=========================================
Hits 819 819
Misses 133 133
Partials 50 50 ☔ View full report in Codecov by Sentry. |
All tests are passing besides known issue with neural sparse search tool:
|
lezzago
approved these changes
Jan 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 1626af1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit 1626af1) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws
pushed a commit
to zhichao-aws/skills
that referenced
this pull request
Jan 30, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…nsearch-project#155) (cherry picked from commit 1626af1) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the default descriptions of the AD and alerting tools in several ways:
It also fixes the parsing of the SearchMonitorsTool to parse
monitor_type
instead oftype
.type
always ismonitor
, butmonitor_type
provides more detail, such as if the monitor is a query-level, bucket-level, or document-level monitor, which is more useful / user-expectedVariety of questions were tested on a test cluster with a provisioned LLM, and this PR is a direct result of where gaps were seen to help increase the effectiveness and accuracy of the tool itself.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.