-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix github ci linux build and RAG tool missing return #477
Conversation
40c6378
to
bd09374
Compare
Signed-off-by: Hailong Cui <[email protected]>
bd09374
to
f4255de
Compare
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
969b80e
to
9805493
Compare
Signed-off-by: Hailong Cui <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
============================================
+ Coverage 81.78% 81.94% +0.15%
- Complexity 193 281 +88
============================================
Files 11 15 +4
Lines 961 1407 +446
Branches 137 202 +65
============================================
+ Hits 786 1153 +367
- Misses 121 176 +55
- Partials 54 78 +24 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hailong Cui <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-477-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f66c53bc78baba65536321b6b5413e76cb3574cd
# Push it to GitHub
git push --set-upstream origin backport/backport-477-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x Then, create a pull request where the |
…ject#477) * fix github ci linux build Signed-off-by: Hailong Cui <[email protected]> * add missing dependencies Signed-off-by: Hailong Cui <[email protected]> * spotless Signed-off-by: Hailong Cui <[email protected]> * add logs for debug Signed-off-by: Hailong Cui <[email protected]> * update security test ci Signed-off-by: Hailong Cui <[email protected]> * fix missing return for RAGTool Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit f66c53b)
…477) (#480) * Fix github ci linux build and RAG tool missing return (#477) * fix github ci linux build Signed-off-by: Hailong Cui <[email protected]> * add missing dependencies Signed-off-by: Hailong Cui <[email protected]> * spotless Signed-off-by: Hailong Cui <[email protected]> * add logs for debug Signed-off-by: Hailong Cui <[email protected]> * update security test ci Signed-off-by: Hailong Cui <[email protected]> * fix missing return for RAGTool Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit f66c53b) * add missing distribution Signed-off-by: Hailong Cui <[email protected]> * fix verssion mismatch Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: zhichao-aws <[email protected]>
Description
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#445
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.