Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Binlong Gao as skills Maintainer #485

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

zhichao-aws
Copy link
Member

Description

Following the process at https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#becoming-a-maintainer, I have nominated and other maintainers have agreed to add Binlong Gao (@gaobinlong) as a co-Maintainer of the skills repository. Binlong has kindly accepted the invitation.

Binlong has been a long-time and consistent contributor to skills since the repo was created.

He built the CreateAnomalyDetectorTool:
#348

He also consistently enhanced the CreateAnomalyDetectorTool:
#376
#399
#423
#457

I believe Binlong would be a valuable addition to the maintainer team.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

add
Signed-off-by: zhichao-aws <[email protected]>
@zhichao-aws
Copy link
Member Author

Please DO NOT merge this PR until it's reviewed by admin team

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (2b76e3c) to head (a6d6f9d).
Report is 38 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #485      +/-   ##
============================================
+ Coverage     81.78%   81.94%   +0.15%     
- Complexity      193      281      +88     
============================================
  Files            11       15       +4     
  Lines           961     1407     +446     
  Branches        137      202      +65     
============================================
+ Hits            786     1153     +367     
- Misses          121      176      +55     
- Partials         54       78      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhichao-aws zhichao-aws merged commit 76f1cfc into opensearch-project:main Jan 23, 2025
4 of 8 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-485-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 76f1cfc807e50c37e2174ed4fb4034ea19cedb45
# Push it to GitHub
git push --set-upstream origin backport/backport-485-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-485-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants