-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi tenancy support #489
add multi tenancy support #489
Conversation
Signed-off-by: Hailong Cui <[email protected]>
So we need to add tenant id as a required parameter? Can we set a possible default value null? I think the code on opensource in front end should not be influenced. |
integration test need to let nerual-search take latest if (streamOutputVersion.onOrAfter(VERSION_2_19_0)) {
out.writeOptionalString(tenantId);
} https://github.com/opensearch-project/neural-search/actions/workflows/maven-publish.yml |
after run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
============================================
+ Coverage 81.78% 81.98% +0.19%
- Complexity 193 281 +88
============================================
Files 11 15 +4
Lines 961 1410 +449
Branches 137 202 +65
============================================
+ Hits 786 1156 +370
- Misses 121 176 +55
- Partials 54 78 +24 ☔ View full report in Codecov by Sentry. |
After neural-search upload latest snapshot, the CIs pass. @Hailong-am does this change need backport? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-489-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 854c64d9d58ce9a8c5d7319906bbb0f0e2466689
# Push it to GitHub
git push --set-upstream origin backport/backport-489-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x Then, create a pull request where the |
@Hailong-am Can we backport manually? |
Will do |
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 854c64d)
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 854c64d)
Description
Add multi tenancy support for tools
Related Issues
opensearch-project/ml-commons#3416
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.