Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #474 to 2.x #490

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

songkant-aws
Copy link
Contributor

  • Improve log pattern tool with cutting edge log pattern parser

  • Minor comment change

  • Address LogPatternTool class comments

  • Address BrainLogParser class comments

  • Address BrainLogParser class comment part02

  • Minor change of input validation logic

  • Address forbiddenAPI check issue

  • Address minor comments in BrainLogParser

  • Tune preprocessing regex and parameters and change related test result

  • Expose variable count threshold parameter configuration for LogPatternTool

  • Minorly tune preprocessing regex


Description

Backport #474 to 2.x

Related Issues

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Improve log pattern tool with cutting edge log pattern parser

Signed-off-by: Songkan Tang <[email protected]>

* Minor comment change

Signed-off-by: Songkan Tang <[email protected]>

* Address LogPatternTool class comments

Signed-off-by: Songkan Tang <[email protected]>

* Address BrainLogParser class comments

Signed-off-by: Songkan Tang <[email protected]>

* Address BrainLogParser class comment part02

Signed-off-by: Songkan Tang <[email protected]>

* Minor change of input validation logic

Signed-off-by: Songkan Tang <[email protected]>

* Address forbiddenAPI check issue

Signed-off-by: Songkan Tang <[email protected]>

* Address minor comments in BrainLogParser

Signed-off-by: Songkan Tang <[email protected]>

* Tune preprocessing regex and parameters and change related test result

Signed-off-by: Songkan Tang <[email protected]>

* Expose variable count threshold parameter configuration for LogPatternTool

Signed-off-by: Songkan Tang <[email protected]>

* Minorly tune preprocessing regex

Signed-off-by: Songkan Tang <[email protected]>

---------

Signed-off-by: Songkan Tang <[email protected]>
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi tenancy related will fixed by another PR

@Hailong-am Hailong-am merged commit 735f9f4 into opensearch-project:2.x Jan 24, 2025
4 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants