Change JS dependency to compileOnly caused by JS a dependency of ml-commons #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmons Signed-off-by: Zan Niu <[email protected]>
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
============================================
+ Coverage 81.78% 82.31% +0.52%
- Complexity 193 355 +162
============================================
Files 11 17 +6
Lines 961 1685 +724
Branches 137 240 +103
============================================
+ Hits 786 1387 +601
- Misses 121 204 +83
- Partials 54 94 +40 ☔ View full report in Codecov by Sentry. |
xinyual
approved these changes
Jan 31, 2025
dhrubo-os
reviewed
Jan 31, 2025
Signed-off-by: Zan Niu <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…ommons (#505) * Change JS dependency to compileOnly caused by JS a dependecy of ml-commons Signed-off-by: Zan Niu <[email protected]> * Add comment for future reference Signed-off-by: Zan Niu <[email protected]> --------- Signed-off-by: Zan Niu <[email protected]> (cherry picked from commit 05af07b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…ommons (#505) * Change JS dependency to compileOnly caused by JS a dependecy of ml-commons Signed-off-by: Zan Niu <[email protected]> * Add comment for future reference Signed-off-by: Zan Niu <[email protected]> --------- Signed-off-by: Zan Niu <[email protected]> (cherry picked from commit 05af07b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
that referenced
this pull request
Jan 31, 2025
…ommons (#505) (#506) * Change JS dependency to compileOnly caused by JS a dependecy of ml-commons * Add comment for future reference --------- (cherry picked from commit 05af07b) Signed-off-by: Zan Niu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
that referenced
this pull request
Jan 31, 2025
…ommons (#505) (#507) * Change JS dependency to compileOnly caused by JS a dependecy of ml-commons * Add comment for future reference --------- (cherry picked from commit 05af07b) Signed-off-by: Zan Niu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change JS dependency to compileOnly caused by JS a dependency of ml-commons in this PR: opensearch-project/ml-commons@f083b7e
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.