-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPLAT-2044 - [vsphere] promote multi-nic to default #2204
base: master
Are you sure you want to change the base?
Conversation
Hello @rvanderp3! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rvanderp3 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rvanderp3: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
For the most part, the associated PRs you have raised are likely not needed. Enabling the gate in this repo will allow the MAO and CPMS to pick up the gate change using their gate observers. There's nothing I can think of in client-go or library-go that would require vendoring this change for a gate promotion either. The installer PR is likely needed though |
Thanks @JoelSpeed for taking a look. I wasn't sure how that feature gate change would propagate. That certainly simplifies things. |
Associated PRs: