Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43823: Downgrade to upstream v1.29.11 for OCP 4.18 #88

Merged
merged 74 commits into from
Nov 16, 2024

Conversation

dfajmon
Copy link

@dfajmon dfajmon commented Nov 15, 2024

Downgrade to v1.29.11. This bug is produced by v1.30.0, where the stack2 SDK is implemented. See the issue. Unfortunately, we can't use the newest release because it's go 1.23, and OCP 4.18 is go 1.22.

I wanted to cherry-pick the fix, but there are big jumps with the dependencies and versions,
e.g., azclient v0.0.31->v0.1.18 (which also produces go1.23 dependency)
So we decided to downgrade to 1.29.11 instead. OCP 4.19 will have release 1.3X.X.

Issue link:
https://issues.redhat.com/browse/OCPBUGS-43823

Diff to upstream v1.29.9:
kubernetes-sigs/azuredisk-csi-driver@v1.29.9...dfajmon:rebase-v1.29.11

Changes between v1.29.9 (OCP 4.17) and v1.29.11 (OCP 4.18):

Full changelogs:
https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.29.11
https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.29.10

@openshift/storage

andyzhangx and others added 30 commits July 6, 2024 14:39
…ot/cherry-pick-2389-to-release-1.29

[release-1.29] test: fix trivy action failure
…iskSlotNum-charts

[release-1.29] feat: add ReservedDataDiskSlotNum to helm-chart
[release-1.29] feat: add tagValueDelimiter parameter
…ry-limits-1.29

[release-1.29] fix: increase azuredisk container memory limits as 600Mi
…ot/cherry-pick-2429-to-release-1.29

[release-1.29] feat: support NVME disk
…permission-1.29

[release-1.29] fix: add pv patch permission with HonorPVReclaimPolicy enabled
…edgezone-1.29-2

[release-1.29] fix: create snapshot failure in edge zone
fix

fix

fix

fix
…-e2e-test-1.29

[release-1.29] test: use workload identity for e2e test
…ot/cherry-pick-2461-to-release-1.29

[release-1.29] fix: checkDiskLun throttling issue
…sioner-5.0.2-1.29

[release-1.30] fix: upgrade csi-provisioner to v5.0.2 to fix pv deletion stuck issue
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 15, 2024
@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-43823, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Downgrade to v1.29.11. This bug is produced by v1.30.0, where the stack2 SDK is implemented. See the issue. Unfortunately, we can't use the newest release because it's go 1.23, and OCP 4.18 is go 1.22.

I wanted to cherry-pick the fix, but there are big jumps with the dependencies and versions,
e.g., azclient v0.0.31->v0.1.18 (which also produces go1.23 dependency)
So we decided to downgrade to 1.29.11 instead. OCP 4.19 will have release 1.3X.X.

Issue link:
https://issues.redhat.com/browse/OCPBUGS-43823

Diff to upstream v1.29.9:
kubernetes-sigs/azuredisk-csi-driver@v1.29.9...dfajmon:rebase-v1.29.11
kubernetes-sigs/azuredisk-csi-driver@v1.29.9...dfajmon:rebase-v1.29.10

Changes between v1.29.9 (OCP 4.17) and v1.29.11 (OCP 4.18):

Full changelogs:
https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.29.11

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member

dobsonj commented Nov 15, 2024

/lgtm
/approve
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fbf4d05 and 2 for PR HEAD 097e72e in total

@dfajmon
Copy link
Author

dfajmon commented Nov 15, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit dcf4766 into openshift:master Nov 16, 2024
10 of 11 checks passed
@openshift-ci-robot
Copy link

@dfajmon: Jira Issue OCPBUGS-43823: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43823 has been moved to the MODIFIED state.

In response to this:

Downgrade to v1.29.11. This bug is produced by v1.30.0, where the stack2 SDK is implemented. See the issue. Unfortunately, we can't use the newest release because it's go 1.23, and OCP 4.18 is go 1.22.

I wanted to cherry-pick the fix, but there are big jumps with the dependencies and versions,
e.g., azclient v0.0.31->v0.1.18 (which also produces go1.23 dependency)
So we decided to downgrade to 1.29.11 instead. OCP 4.19 will have release 1.3X.X.

Issue link:
https://issues.redhat.com/browse/OCPBUGS-43823

Diff to upstream v1.29.9:
kubernetes-sigs/azuredisk-csi-driver@v1.29.9...dfajmon:rebase-v1.29.11

Changes between v1.29.9 (OCP 4.17) and v1.29.11 (OCP 4.18):

Full changelogs:
https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.29.11
https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.29.10

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver
This PR has been included in build ose-azure-disk-csi-driver-container-v4.19.0-202411160207.p0.gdcf4766.assembly.stream.el9.
All builds following this will include this PR.

@dfajmon dfajmon deleted the rebase-v1.29.11 branch November 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants