Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: migrate from bindata to go:embed #1370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sanchezl
Copy link
Contributor

  • remove bindata tool
  • migrate to go:embed

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2024
@openshift-ci-robot
Copy link

@sanchezl: This pull request explicitly references no jira issue.

In response to this:

  • remove bindata tool
  • migrate to go:embed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dusk125 and Elbehery November 19, 2024 14:34
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanchezl
Once this PR has been reviewed and has the lgtm label, please assign hasbro17 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 27, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 27, 2025

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation c6f92ba link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown c6f92ba link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown c6f92ba link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery c6f92ba link false /test e2e-aws-etcd-recovery
ci/prow/okd-scos-images c6f92ba link true /test okd-scos-images
ci/prow/e2e-aws-cpms c6f92ba link true /test e2e-aws-cpms
ci/prow/unit c6f92ba link true /test unit
ci/prow/verify-deps c6f92ba link true /test verify-deps
ci/prow/e2e-metal-ipi-ovn-ipv6 c6f92ba link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-agnostic-ovn c6f92ba link true /test e2e-agnostic-ovn
ci/prow/e2e-metal-assisted c6f92ba link true /test e2e-metal-assisted
ci/prow/verify c6f92ba link true /test verify
ci/prow/e2e-aws-ovn-serial c6f92ba link true /test e2e-aws-ovn-serial
ci/prow/images c6f92ba link true /test images
ci/prow/e2e-aws-ovn-etcd-scaling c6f92ba link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-operator c6f92ba link true /test e2e-operator
ci/prow/e2e-aws-ovn-single-node c6f92ba link true /test e2e-aws-ovn-single-node
ci/prow/e2e-agnostic-ovn-upgrade c6f92ba link true /test e2e-agnostic-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants