-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-1854: make use of include
/exclude
CEL
#2215
base: master
Are you sure you want to change the base?
Conversation
@smg247: This pull request references TRT-1854 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/hold to merge after #2214 |
@smg247: This pull request references TRT-1854 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4abe9c8
to
db6b8e5
Compare
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/hold cancel |
/hold to figure out test mapping with the name changes prior to merge |
77fa839
to
0e529d9
Compare
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@smg247: This pull request references TRT-1854 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
include
/exclude
CEL and remove SKIPPED
annotationsinclude
/exclude
CEL
/hold cancel |
…e use of environment flags for SKIPPED tests
0e529d9
to
54463b0
Compare
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smg247, stbenjam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@smg247: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-tests-extension
introduces a new way to skip upstream tests based on environment flags andinclude
/exclude
fields present on the listed tests. This PR translates the existing test skips to that functionality, but leaves the annotations alone. They will be removed in a later PR.I have generated a diff of the output of
k8s-tests-ext list
prior to, and after this change for verification purposes. This diff was generated when we were removing the annotations from the test names, that part will no longer be happening with this PR.There will be a followup to this to translate the other annotations, and eventually the framework itself.