-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support addr:place tag in Address field #9603
Conversation
using the "old" `addr:street`-only field on some countries which don't appear to use place-based addresses (according to current use in the OSM database): * Australia * Finland * Iceland * Liechtenstein * Netherlands * Norway * Monaco * Latvia * Peru * Bolivia * China * Ukraine * Taiwan (uses both addr:place and add:street in parallel!) * India * Canada * United States
as in this case it is likely a mapping mistake where the "place" should actually be addr:city (or addr:suburb, etc.)
this assumes that the address format included both fields as a "hacky" workaround of iD's inability to choose between streets and places from a single field. This is (at the momemt) only based on the observation that before the format was introduced in iD in mid-2016, there were only a very small number of addresses in Taiwan with both tags, and the number increased only after iD started to show fields for both tags, and even today only a very small percentage of addresses have both tags set (approx 2.1k out of 1.6M).
@blackboxlogic asked about using The U.S. has some alternative address formats that would probably require a more significant rearchitecture of this field. For example, some rural addresses use rural delivery route numbers, which have no established tagging, while others use P.O. boxes ( Puerto Rico has a unique series of standard address formats. There’s some scattered usage of |
This adds support for the
addr:place
tag in the Address field (closes #2898).A demo instance is available.
This changes the "Street" subfield of the Address field to a combined "Street / Place" input element which is little bit more clever:
addr:street
, but does have anaddr:place
, it is displayedaddr:street
for streets,addr:place
for places (and in case a different tag was previously present, it is removed automatically)2addr:street
tag is used as a fallbackNot all countries have this "enabled", as in some countries the use of place names in addresses is non-existent in OSM (e.g. Latvia), or use a special "non-standard" addressing scheme which allows for both
addr:street
andaddr:place
to be set at the same time (e.g. Czech Republic).The following countries I'm currently unsure about, and would really appreciate some feedback by the local community how they would like to be handled in iD:
addr:street
andaddr:place
enabled (see Add Taiwan (R.O.C.) address format #3261), but I don't know whether this was just done as a hacky workaround to allow map eitheraddr:street
oradr:place
(but never both), or if it is actually possible for an address in Taiwan to have both tags set at the same time. I assumed that the latter is the case, as before Add Taiwan (R.O.C.) address format #3261 was merged only 63 out of ~120k addresses had both tags in the country (for comparison: today the proportion is still pretty small, but the absolute number has increased significantly to 2.1k out of 1.5M). It would be nice if someone from the local community could confirm or deny this. //cc @david082321addr:place
seems to be very rarely used, but one pattern I noticed is for addresses on sites which are only accessible by boat (example 1, 2). In this PR I have currently not enabled theaddr:place
tag for these countries (my reasoning for this was that offering place names in the dropdown list of the "street field" could be confusing if it is such a rare thing to see in an actual address). However, this could be enabled easily. It would be nice to hear from the community what approach would be preferred in the US and Canada.addr:street
-only field, because they seem to not useaddr:place
in practice (and for these countries I had to make a decision because they already had localized address formats defined in iD): Australia, Finland, Iceland, Liechtenstein, the Netherlands, Norway, Monaco, Latvia, Peru, Bolivia, China, Ukraine, India (highlighted are the countries which I am a bit unsure about, similar to the US and Canada above, and would especially appreciate some feedback about). If further countries should be included in this list, it would be good to know what the local address format should look like (i.e. in which order the different parts of an address should be arranged into a typical list of "address rows").Footnotes
Map features with a
place=*
tag orboundary=administrative
objects withadmin_level>8
↩Note that this implies that if an address had (for whatever reason — most probably a mapping mistake) both
addr:street
andaddr:place
, selecting any option from the dropdown would remove the other tag from the type which one has selected (e.g. when selecting a street name, theaddr:place
would be removed). ↩