-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selecting multiple genders for shop=hairdresser #894
Comments
So both the original meaning of the tag and the meaning of "unisex" used by the common native speaker for restrooms is a restroom without segregation by sex. So So, the implication above is for data consumers to make, not for editor software. i.e. data consumers wanting to find all restrooms that can be used by women will want to filter for If I remember correctly, the current UI decision was rationalized by previous iD maintainers saying that ideally, there would be one |
There’s something to be said for this approach, but there’s nothing in the UI to guide the user to this realization, unlike with, say, sidewalks, in which the path of least resistance is currently to map a separate way. Not every native English speaker has a correct understanding of the term “unisex”, let alone non-native speakers. But if I’m reading this ticket correctly, it’s actually about |
|
This might be better opened on the https://github.com/openstreetmap/id-tagging-schema repo, as the (one-line) change is to solve it is: https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/gender.json#L2 "type" field from "radio" to "semiCombo". |
Thanks for the hint @JesseWeinstein , but are you sure just changing that I've tried looking, but it seems that all occurrences I found that use And that doesn't seem like it would accomplish what we need for |
yes! openstreetmap/iD#3954 is the issue that everyone here needs to read. Switching from a radio to a semiCombo won't fix the problem. The accepted tagging for gendered things does not work like other multi valued tags in OSM. Solution is either - need to wait for better tags to be proposed (which was where openstreetmap/iD#3954 left things), or replace the existing radiobutton gender field with a bunch of gender checkbox fields, or develop a new kind of special field that can manage all the different tags. |
Thanks @bhousel! That is how it seemed to me too, that one would need 3 separate checkboxes ( Of course, it would look nicer if those 3 separate checkboxes could be grouped somehow together, but that would be just visual fluff (i.e. functionality would remain the same; but it would use less screen and look nicer). However, I wasn't able to find a tagging that works that way, and you confirm that such nicer layout not exist yet, so one would currently be fixed on using existing As an aside, disadvantage of UI like for |
Fixed by switching the field to the Currently, this does not display mapped I do plan to add support mapping of |
Hey that is great! I did not know about |
Pedantically, I know of a hairdresser which tried to be “gender neutral”, rather than “men & women”. But your general point is correct. Unlike toilet (where “male & female” ≠ “unisex”), in the context of hairdressers, one can treat them mostly as the same. |
Description
Currently, for shop=hairdresser, iD allows selecting only one of the gender values male=*, female=* and unisex=*, i.e. UI control is radio-button.
That however presents a problem when users try to edit objects that have more than one value set - most commonly combination of
male
+female
tags, especially due tounisex=*
ambiguity/controversy documented on its wiki page and related iD issues (like related #895 and openstreetmap/iD#7427).Request: It would be preferable if iD allowed entering all three gender keys (
male
,female
,unisex
) via checkboxes instead of radiobuttonsThis is how most other popular editors do it (screenshots of JOSM and Vespucci attached). Current iD handling of that situation is very subtle, and unless user has display of raw tags displayed and uses that instead of user-friendly presets, is likely to result in unintended modification / retagging / data loss on edits. (see iD picture, in which iD would_ silently remove all gender tags except one that was selected via radio button_ if it were clicked on, regardless of their previous combinations/values)
Screenshots
The text was updated successfully, but these errors were encountered: