-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hairdresser quest #4909
Hairdresser quest #4909
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I think it does not need resurvey. For the icon, you can just use scissors. There is already a scissors SVG in the resources, you can reuse that. |
This comment was marked as resolved.
This comment was marked as resolved.
I don't quite understand why you need the "is signed as..." wording. I think it should be Somerton along the lines of "for whom is hairdresser?" ... with answers like :
- men
- women
- anyone / not signed
After all, it doesn't have to be always signed, it could be clear from the context, logos or names. E.g. a hairdresser with "barber" in its name is likely for men only (that is, for men's *hairstyles*) and a hairdresser that advertises with "beauty salon, fabulous nails and hairstyles" is something that is rather only targeted at women.
Am 30. März 2023 01:00:56 MESZ schrieb Matija Nalis ***@***.***>:
I'm still struggling with good title for the quest being asked:
- **What are the signed customers of this hairdresser?**
(current from [#4833](#4833 (comment)), but sounds somewhat strange to me)
- Which customers are indicated on the sign for this hairdresser?
- What customers are signed on this hairdresser?
- What customers are featured on this hairdresser's sign?
The idea is to somehow indicate that user should enter what is marked on the sign / doors of the hairdresser, and not to imply that other customers (e.g. nonbinary) are forbidden/unwelcome (see #4833)
so solutions like:
- Which customers does this hairdresser serve?
- What customers are serviced here?
are probably less then ideal.
Any suggestions, especially from native English speakers?
@Discostu36 @peternewman @dbdean
(other than this wording issue, this PR is complete)
--
Reply to this email directly or view it on GitHub:
#4909 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
OK. ChatGPT however says 😺 :
And gives more alternatives, of which I've settled for short and simple "Which customers visit this hairdresser?" Unless someone feels the need to suggest something better, I'll mark this PR as ready tomorrow. |
app/src/main/java/de/westnordost/streetcomplete/quests/hairdresser/Hairdresser.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/hairdresser/AddHairdresser.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/hairdresser/AddHairdresser.kt
Outdated
Show resolved
Hide resolved
I understand that you wanted to create an issue or (better) a PR over at the iD tagging schema repo if the way how iD tags it conflicts with this quest? |
Yes, I'm wading through existing iD gender issues currently, so I have background and can reference them in new issue (or contribute to existing one with same problem, if present) iD uses radio button so only one of fields So while not actually conflicting, it definitely does not handle it in the best possible way... |
While iD does show multiple gender tags, it does it in subtle way that is (IMHO) somewhat likely to be missed by its users. The suggestion for UI improvement (i.e. use checkboxes instead of radiobuttons, like JOSM and Vespucci do) has been suggested at openstreetmap/id-tagging-schema#894 |
I agree about not using “whom”. Many people who learn English as a second language, use “whom” because in the past that was Proper Grammer™, however it sounds very old fashioned, and unnatural.
A problem with this is that it refers to the type of customers, which regular visit that place. Someone standing on the street, can't know what happens regularly, they can only look at the sign. They cannot know the regular occurances. I think “Who is this hairdresser for?” (while showing the gender options) is pretty clear & better. |
Closes: #4833
TODO:
yes, debug APK at https://github.com/mnalis/StreetComplete/actions/runs/4600306640