Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contact:instagram field for POIs #1019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add contact:instagram field for POIs #1019

wants to merge 1 commit into from

Conversation

sbraz
Copy link

@sbraz sbraz commented Sep 30, 2023

Hi, I based this on #859, hopefully I got it right :)

@matkoniecz
Copy link
Contributor

Is there some way to get this autodeployed code preview? Why it has not appeared here?

@sbraz sbraz force-pushed the contact_instagram branch from e92f96e to 87cabc3 Compare November 27, 2023 20:55
@sbraz
Copy link
Author

sbraz commented Nov 27, 2023

Let's see if force-pushing helps.

@github-actions GitHub Actions
Copy link

🍱 You can preview the tagging presets of this pull request here.

tyrasd
tyrasd requested changes Dec 16, 2023
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for this. It generally looks good to me. Only the field label feels a bit too long. See below for a suggestion to shorten it.

image

Btw: I had to manually trigger the build, as this is your first PR on this repository. You can now try the changes out on the preview build.

data/fields/contact/instagram.json Outdated
{
"key": "contact:instagram",
"type": "url",
"label": "Instagram account name (also used on Threads) or full Instagram URL",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "Instagram account name (also used on Threads) or full Instagram URL",
"label": "Instagram Account Name or URL",

tyrasd
tyrasd reviewed Dec 16, 2023
View reviewed changes
data/fields/contact/instagram.json Outdated
"key": "contact:instagram",
"type": "url",
"label": "Instagram account name (also used on Threads) or full Instagram URL",
"placeholder": "account_name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full URLs seem to be slightly more popular at first glance (see taginfo) and are probably easier to copy-paste, so maybe use something like this for the placeholder:

Suggested change
"placeholder": "account_name"
"placeholder": "https://www.instagram.com/LocalBusiness"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer using the account name because I've never seen a business advertise their Instagram with the URL, but I've updated the PR to use a URL. I took the liberty of using https://www.instagram.com/openstreetmap/ which seems like a legitimate Instagram account.

@sbraz sbraz force-pushed the contact_instagram branch from 87cabc3 to d997db6 Compare December 17, 2023 00:48
@sbraz sbraz force-pushed the contact_instagram branch from d997db6 to d045c44 Compare December 17, 2023 00:51
@sbraz
Copy link
Author

sbraz commented Dec 17, 2023 •
edited
Loading

You can now try the changes out on the preview build.

Thanks and also thanks for the review, I think this push addresses all comments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new-field
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbraz @matkoniecz @tyrasd