Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and fix a cuisine typo in tagging #266

Closed
wants to merge 1 commit into from

Conversation

peternewman
Copy link
Contributor

Off the back of #252

@matkoniecz
Copy link
Contributor

7 cases worldwide, may be better suitable for manual fix https://taginfo.openstreetmap.org//search?q=cuisine%3Dportugese

@peternewman
Copy link
Contributor Author

Possibly, but as your typo shows there's no guarantee more won't appear in future.

@1ec5
Copy link
Contributor

1ec5 commented Nov 11, 2021

The deprecation feature is primarily intended for intentional changes in the tagging conventions, but there’s such a long tail of possible typos. Better to merge #252 and enhance iD so that the suggested values are filtered based on fuzzy matching based on edit distance, similar to how preset search currently catches typos.

@matkoniecz
Copy link
Contributor

JOSM already detect automatically such typos (close matches to values in presets).

Maybe making specialized script/editor that is using https://github.com/codespell-project/codespell dictionary and/or fuzzy matching, with human reviewing typos would be useful?

@1ec5
Copy link
Contributor

1ec5 commented Nov 11, 2021

A dictionary would be for catching typos in freeform text, but since values such as portuguese are already known, iD can simply rank suggestions by edit distance: openstreetmap/iD#8802.

@tyrasd tyrasd added the wontfix This will not be worked on label Dec 10, 2021
@tyrasd tyrasd closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants