improve bookmarking

[tophf]

Fixes #952.

Line number area accepts mouse clicks now:

• Left button toggles bookmark
• Right button goes to the next bookmark (or previous if Ctrl is held)
• Middle button selects all bookmarked positions, useful when multi-editing

Changed the default style so it's more noticeable especially in the dark themes:

As for cycling through all sections, that's not reliably possible with the way sublime bookmarks work as their next/previous order isn't based on a line number but rather on the bookmarking order so it may jump all around the place within one section. This implementation seems weird but I'm not sure we can convince CodeMirror's author so maybe I could just re-implement bookmarking myself one day. That would make it available for all keymaps not just sublime.

[narcolepticinsomniac]

LGTM. Might be cool if scrolling line jumps always centered, like swatch cycling. It'd be kind of a shame if this goes unnoticed, but I'm not sure there's a great visual indicator which won't be distracting though.

Mostly unrelated, I'd like to get rid of all the orange eventually. I get why we're using it in search and bookmarks, because it's a solid highlight color that works well, but damn it's fugly. Cyan stands out pretty well against most backgrounds too, so some shade of it must work decently.

[tophf]

Switched to cyan. I'm fine with orange but cyan matches our palette especially in the sectioned editor which has a focus outline of the same color.

[tophf]

scrolling line jumps always centered

Done.

[narcolepticinsomniac]

Everything LGTM. You think we should at least give em hover backgrounds to indicate action? NBD either way. Up to you.

[tophf]

The cursor is changing, I thought that's enough.

[narcolepticinsomniac]

Cursor changes after you click it. I'm just concerned that no one will realize they're nclickable in the first place, particularly since they never have been previously.

[tophf]

Ah. Maybe you can find a satisfactory solution then. If not, I'll try something tomorrow.

[tophf]

Turns out the feature works with all keymaps as long as we simply load sublime.js which we will always do. So now cursor:pointer is always present on line numbers. The only missing indication would be the right-click but maybe the users will find it eventually. Someone could add it to wiki as well.

[dnknn]

Someone could add it to wiki as well.

https://github.com/openstyles/stylus/wiki/Hotkey-shortcuts#editor-shortcuts
May need to be modified

[tophf]

We can find a way to indicate the feature later.

[dnknn]

scrolling line jumps always centered

Done.

@tophf Now, right-click on the line-number can do this, but can let F2/Shift+F2 do the same this (jumps always centered) ?

[tophf]

Yeah that's good for consistency. Done in c635f2e.

[tophf]

Apparently it's because your section is taller than window. I'll look into that.

[tophf]

Should be fixed in a91183e.