Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show sublime bookmarks #951

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Conversation

tophf
Copy link
Member

@tophf tophf commented May 31, 2020

  • Implements CM-marked vision on the linenumber? #949 since CodeMirror's author doesn't want to. The default style is really primitive: it's a gradient from currentColor to transparent over the line number.

  • Removes the no longer needed optimization which is included in CodeMirror.

@dnknn
Copy link

dnknn commented May 31, 2020

Wow, show bookmarks needs to change many lines of code..Very thanks♪(・ω・)ノ for your hard work

@narcolepticinsomniac
Copy link
Member

narcolepticinsomniac commented Jun 1, 2020

Playing around with it a little, I can't help but think how much cooler and more useful it'd be if it was more user-friendly.

Click line numbers to bookmark/unbookmark, some kinda convenient click function to cycle, and it'd be way more useful if it actually cycled through all sections.

Seems to work as intended though, so we can merge as-is if you're not into these suggestions.

@dnknn

This comment has been minimized.

@tophf
Copy link
Member Author

tophf commented Jun 1, 2020

Nah, merge this as is. To make this mouse-controlled I would have to decouple the entire bookmarking functionality from sublime keymap so it works regardless of the keymap selected. This is something to do in the future.

@narcolepticinsomniac narcolepticinsomniac merged commit a1b0eb7 into openstyles:master Jun 1, 2020
@narcolepticinsomniac
Copy link
Member

Fair enough. Figured it might be tedious. Hope you keep it mind though.

I do think that what I'm describing would become a pretty popular little feature fairly quickly, particularly with a little visual indication of new functionality.

If editing large styles, I'm constantly jumping back and forth between different code blocks in different sections, by utilizing "find", which works, but is kind of a PITA comparatively.

@tophf tophf deleted the bookmarks branch June 1, 2020 04:56
@tophf
Copy link
Member Author

tophf commented Jun 1, 2020

I can forget... Better create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants