fix(plugins/materials): fix new app with no page should not set url page id to undefined #1061
Conversation
…age id to undefined
WalkthroughThe pull request modifies the Changes
Sequence DiagramsequenceDiagram
participant User
participant Page
participant Browser
User->>Page: Trigger page navigation
Page->>Page: initPage()
Page->>Page: goPage(pageId)
Page->>Browser: Update URL with pageid
Page->>Page: Post location history change
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
packages/plugins/materials/src/composable/useResource.js (1)
41-55: Consider architectural improvements for better maintainability.The current implementation mixes URL management with page initialization logic. Consider these architectural improvements:
- Create a dedicated URL management service
- Add explicit error handling for edge cases
- Document the fallback behavior
Example structure:
// urlService.ts interface URLService { setPageId(pageId: string | undefined): void; getPageId(): string | undefined; } // pageService.ts interface PageService { initPage(pageInfo: PageInfo): void; handleEmptyPage(): void; }This separation would make the code more maintainable and easier to test. Would you like me to help with this refactoring?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/plugins/materials/src/composable/useResource.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: push-check
…age id to undefined (opentiny#1061)
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
空应用(没有页面的应用)会跳 pageid=undefined， 导致解析器认为pageid是undefined，会去查询pageid为'undefined'相关的内容
Issue Number: N/A
What is the new behavior?
如果没有pageid就跳url
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes