fix: header content lost when dragging from outline tree

[gene9831]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

问题：拖拽Header组件会导致内容消失
定位：大纲树转换schema数据时，如果某个节点children属性不是数组，会删除children字段。Header组件的children是显示内容
解决方案：如果某个节点children属性不是数组，则不做其他处理

What is the current behavior?

拖拽Header组件会导致内容消失
Issue Number: #1137

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Refactor
  • Simplified the tree processing logic to ensure consistent handling of nested items in the display.

[coderabbitai]

Walkthrough

The change in this pull request modifies the logic for handling tree node children in the tree component. The code now uses a direct check with Array.isArray to determine if a node's children should be processed, instead of relying on a type-checking function. The removal of the typeOf import and the condition that previously deleted non-array children simplifies the flow of the component, ensuring that translateChild(item.children) is only called when appropriate.

Changes

File	Change Summary
packages/.../Main.vue	Removed import of typeOf, replaced type checking with a direct Array.isArray check, and eliminated conditional deletion of item.children if not array.

Sequence Diagram(s)

sequenceDiagram
    participant Main as Main.vue
    participant Checker as Array Check
    Main->>Checker: Evaluate child node type (Array.isArray(child))
    alt Child is array
        Checker->>Main: Returns true
        Main->>Main: Call translateChild(item.children)
    else Child is not array
        Checker->>Main: Returns false
        Main->>Main: No processing done
    end

Loading

Possibly related PRs

• feat: outline tree support dragging #1050: Introduces a DraggableTree component and enhances dragging support, which may interact with tree handling logic.

Suggested labels

bug, refactor-main

Suggested reviewers

• rhlin
• hexqi

Poem

In lines of code I take a hop,
A clearer path where bugs now stop.
No deletion here, just a gentle check,
Array logic clean with no defect.
I, the rabbit, cheer this tweak—
Hopping through code, so swift and sleek!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ea78ad and 3198ede.

📒 Files selected for processing (1)

• packages/plugins/tree/src/Main.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

🔇 Additional comments (1)

packages/plugins/tree/src/Main.vue (1)

74-76: Approved: Fix for header content loss during drag operations

This change correctly addresses the issue where header content would disappear when dragging from the outline tree. By replacing the type check and deletion of non-array children with a simple Array.isArray check, the component now preserves the content of nodes whose children property is not an array.

The fix is simple but effective - now the recursive processing only happens for array-type children, without modifying other types of content.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.