Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:modify style #981

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix:modify style #981

merged 1 commit into from
Jan 2, 2025

Conversation

zhangjuncao
Copy link
Contributor

@zhangjuncao zhangjuncao commented Dec 31, 2024

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

1.区块名称长度样式调整
image

2.样式宽度悬浮和直接显示宽度一致
image

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style Updates
    • Enhanced plugin setting header title display with text truncation
    • Improved block group selection and editing layout
    • Adjusted input and numeric input component padding in theme base styles

Copy link
Contributor

coderabbitai bot commented Dec 31, 2024

Walkthrough

This pull request focuses on UI refinements across multiple files, primarily addressing styling and layout improvements. The changes involve adjusting CSS properties in PluginSetting.vue, BlockGroup.vue, and component-common.less to enhance text truncation, input spacing, and overall visual consistency. The modifications are purely stylistic, aimed at improving user interface presentation without altering the underlying component logic or functionality.

Changes

File Change Summary
packages/common/component/PluginSetting.vue Added CSS properties to .plugin-setting-header-title for text truncation with ellipsis
packages/plugins/materials/src/meta/block/src/BlockGroup.vue Updated input and label styles to set fixed width and handle text overflow
packages/theme/base/src/component-common.less Modified padding for .tiny-input__inner and .tiny-numeric__input-inner classes

Suggested labels

refactor-main, enhancement

Suggested reviewers

  • hexqi
  • chilingling

Possibly related PRs

Poem

🐰 Pixels dance with grace and might,
Styling tweaks, a rabbit's delight!
Ellipsis here, padding there,
UI magic beyond compare,
Code refined with bunny flair! 🎨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Dec 31, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/plugins/materials/src/meta/block/src/BlockGroup.vue (1)

432-432: Explicit width might limit flexible designs
Currently, setting .tiny-input__inner to a fixed width: 180px; enforces a rigid layout. If there are future design changes or localized text expansions, this might not be optimal. Consider making this width configurable or using a max-width to retain responsiveness.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da356e1 and 8e2b329.

📒 Files selected for processing (3)
  • packages/common/component/PluginSetting.vue (1 hunks)
  • packages/plugins/materials/src/meta/block/src/BlockGroup.vue (3 hunks)
  • packages/theme/base/src/component-common.less (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/common/component/PluginSetting.vue
🔇 Additional comments (5)
packages/plugins/materials/src/meta/block/src/BlockGroup.vue (2)

442-444: Improved padding for .tiny-button
These adjustments help ensure more compact spacing for confirmation buttons. This looks consistent with the overall style approach.


462-467: Efficient text truncation
Defining width, overflow, text-overflow, and white-space ensures long group names are truncated with an ellipsis. This aligns well with the PR’s objective to handle block name lengths gracefully.

packages/theme/base/src/component-common.less (3)

15-17: Space for dropdown icons
Increasing padding-right to 30px in .tiny-input__inner ensures sufficient space for dropdown icons, preventing layout overlap. This change is consistent with the PR’s stylistic goals.


504-504: Consistent numeric field padding
The reduced padding from 0 42px 0 12px to 0 20px 0 12px is more compact, aligning numeric inputs with the rest of the form styling. This helps maintain visual consistency.


525-525: Unit label spacing
Adjusting padding for .tiny-numeric__input-inner ensures the unit label is properly spaced. This minor tweak improves readability and matches the new design patterns.

@hexqi hexqi merged commit f4d3215 into opentiny:release/v2.1.0 Jan 2, 2025
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 2, 2025
14 tasks
chilingling pushed a commit that referenced this pull request Jan 3, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jan 26, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants