Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligatures not rendering #479

Closed
dragondgold opened this issue Jun 23, 2021 · 3 comments · May be fixed by #564
Closed

Ligatures not rendering #479

dragondgold opened this issue Jun 23, 2021 · 3 comments · May be fixed by #564

Comments

@dragondgold
Copy link

Expected Behavior

The font should be rendered with ligatures:
image

Current Behavior

The font is rendered without ligatures, although they are being detected in the gsub table as far as I understand:

image

image

Possible Solution

I don't know actually, I don't have much experience on the font file internals, but I'm open to working on the issue if someone is willing to guide me a little

Steps to Reproduce (for bugs)

  1. Go to https://opentype.js.org/
  2. Upload the TTF font Pecita.zip
  3. Make sure ligatures are enabled
  4. Write the word "quick" or any other word, the font is not rendered with ligatures

Context

I have an app where users can write text on the browser using any font and export the text as SVG, it works great for most fonts, some of them have issues, converting them from TTF to OTF or vice-versa or re-exporting them with FontForge fixes most issues, in this case, I couldn't fix the issue by doing that in this case.

Your Environment

  • Version used: Opentype.js 1.3.1
  • Font used: Pecita.zip
  • Browser Name and version: Chrome Version 91.0.4472.114
  • Operating System and version (desktop or mobile): Windows 10 21H1 x64
@ILOVEPIE
Copy link
Contributor

ILOVEPIE commented Feb 3, 2023

You have to ask opentype.js to use ligatures, by default it does not.

@Connum
Copy link
Contributor

Connum commented Feb 5, 2023

As it says "make sure ligatures are enabled" in the steps to reproduce, I think we need to look into this. Or did you try it out and it worked on your end @ILOVEPIE? In that case it might have been fixed in the meantime, as the issue is already 2 years old.

@ILOVEPIE
Copy link
Contributor

ILOVEPIE commented Feb 5, 2023

The cause of this has been determined, I've created a new issue with the specific information on the bug, we will move discussion of this issue to there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants