Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required Ligatures (rlig) are not implemented for latin script. #554

Open
ILOVEPIE opened this issue Feb 5, 2023 · 2 comments · May be fixed by #564
Open

Required Ligatures (rlig) are not implemented for latin script. #554

ILOVEPIE opened this issue Feb 5, 2023 · 2 comments · May be fixed by #564
Labels
bug font features Spec Related to the implementation of the Opentype specification
Milestone
Release 2.0.0

Comments

@ILOVEPIE
Copy link
Contributor

ILOVEPIE commented Feb 5, 2023

Expected Behavior

rlig stands for required ligature, liga is optional ligature

Current Behavior

rlig is only on for arabic script.

Possible Solution

Add rlig to all scripts or just hard-code it to be on by default.

Steps to Reproduce (for bugs)

see #479 for reproduction steps.

Context

Some fonts use rlig instead of liga because they don't want the ligatures to be toggleable.
@ILOVEPIE ILOVEPIE added this to the Release 2.0.0 milestone Feb 5, 2023
@ILOVEPIE ILOVEPIE added the bug label Feb 5, 2023
@Connum
Copy link
Contributor

Connum commented Feb 5, 2023

I wouldn't hardcode it or make it un-disableable (is that an actual word?). An application like a font editor might want to disable them temporarily for debugging or demonstration purposes. I would just turn them on by default.

@ILOVEPIE
Copy link
Contributor Author

ILOVEPIE commented Feb 5, 2023

At the very least we should handle rlig for latin text.

@ILOVEPIE ILOVEPIE changed the title Rlig should always be active, for all scripts and should not be able to be disabled. rlig should be enabled by default for all scripts. Feb 6, 2023
@ILOVEPIE ILOVEPIE changed the title rlig should be enabled by default for all scripts. Rlig is not implemented for latin script. Feb 6, 2023
@ILOVEPIE ILOVEPIE added the Spec Related to the implementation of the Opentype specification label Feb 6, 2023
@ILOVEPIE ILOVEPIE changed the title Rlig is not implemented for latin script. Required Ligatures (rlig) are not implemented for latin script. Feb 6, 2023
@Connum Connum linked a pull request Feb 14, 2023 that will close this issue
Draft
8 tasks
@ILOVEPIE ILOVEPIE modified the milestones: Release 2.0.0, Font Writhing Mar 1, 2023
@lwollnikowski lwollnikowski mentioned this issue Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug font features Spec Related to the implementation of the Opentype specification
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging a pull request may close this issue.

Handle rlig for latin script Connum/opentype.js-next
2 participants
@ILOVEPIE @Connum