Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS/2 usFirstCharIndex #196

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Jun 22, 2016

Hi 😉

I just fixed a bug with the usFirstCharIndex see reports from Microsoft's Font Validator:
screenshot 2016-06-22 at 15 49 19
E2130 The usFirstCharIndex is not valid - actual = 0x0000, calculated = 0x0020

After fixing it:
P2100 The usFirstCharIndex and usLastCharIndex fields are valid - first = 0x0020, last = 0x005f

@Jolg42
Copy link
Member Author

Jolg42 commented Jun 22, 2016

@fdb The Travis result is not what I was expected… Maybe it was a temporary error?
screenshot 2016-06-22 at 16 13 29

@fdb
Copy link
Contributor

fdb commented Jun 22, 2016

Thanks! Looks good. Nice that you're fixing those pesky validation errors.

I don't understand the Travis CI bug either -- but I've had it crash before. Here specifically it's mentioning babel, which we don't use directly.

@fdb fdb merged commit 5bd2de0 into opentypejs:master Jun 22, 2016
@fdb
Copy link
Contributor

fdb commented Jun 22, 2016

Uh-oh, Travis is sh*tting all over itself. Sometimes I hate the crapfest that is node.js....

@Jolg42
Copy link
Member Author

Jolg42 commented Jun 23, 2016

Thanks 😉
Btw, for Microsoft's Font Validator it was the only error left, the rest in yellow are warnings (complete list below).

General Font Information
Error code  Message     Details
W0022   Recommended table is missing    DSIG


OS/2

Error code  Message     Details
W2106   The version number is valid, but less than 5    3
W2105   PANOSE(tm) is undefined. Font mapping may not work properly     
W2101   A CodePage bit is set in ulCodePageRange, but the font is missing some of the printable characters from that codepage   bit #0, Latin 1 (190 missing, first ten missing chars are: U0021 U0022 U0023 U0024 U0025 U0026 U0027 U0028 U0029 U002A)


cmap

Error code  Message     Details
W0302   The table does not contain any Apple subtables  
W0301   Apple logo mapping test not performed, cmap 1,0 not present     
W0305   Character code U+20AC, the euro character, is not mapped in cmap 3,1    


head

Error code  Message     Details
W1314   fontRevision is not consistent with the font's version string   revision: 1.000, version: 0.1
W1305   The lowestRecPPEM value may be unreasonably small   lowestRecPPEM = 3


hhea

Error code  Message     Details
W1406   Descender is different than OS/2.usWinDescent. Different line heights on Windows and Apple  hhea.Descender = -200, OS/2.usWinDescent = 80

@Jolg42 Jolg42 deleted the fix-usFirstCharIndex branch July 28, 2016 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants