Add writing support for lookup type 6, formats 1 and 3 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/Connum/opentype.js into add-gsub-lookup-type-2-multiple-sub
Inter contains format 6, type 2. I ran into the error "lookup type 6 format 2 is not yet supported" when trying to modify Inter. |
|
@calebmer if it's of any help, I found that the 3.0 release of Inter works with this library. Seems like the format 2 thing has been introduced within that release cycle. |
|
Oh thanks! I ended up using Python's fonttools ttx for the modification I needed to make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows to write fonts containing tables of lookup type 6, in formats 1 and 3.
Motivation and Context
Fonts containing such tables would simply fail when writing. Lookup type 6 is needed for the Chaining Contextual Substitution feature.
I originally planned to implement all three formats for this type, but this PR now only implements format 1 and 3 and will still throw a descriptive error when encountering format 2, for the following reasons:
If anyone can provide a font using format 6, type 2, I would be happy to look into this and implement it, if and when my free time allows. I would also be interested in implementing all other missing types (5, 7 and 8) in order to complete the writing functionality of the library.
How Has This Been Tested?
I added test cases for writing both formats according to the specs. I also loaded and saved several font files containing such tables, checking that they contained the corresponding tables afterwards.
Screenshots (if appropriate):
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).