Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nGraph] MatMul - Remove fused op and align output shape inference #2866

Merged

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Oct 27, 2020

To follow MatMul spec update for 1D tensors this PR introduces FusedOp and decompose removal without changing current MatMul output shape inference logic (numpy/onnx aligned).
Based on previous PR #2212 that follows rather current spec logic.

@mitruska mitruska changed the title Remove fused op and align output shape inference [nGraph] MatMul - Remove fused op and align output shape inference Oct 28, 2020
@mitruska mitruska marked this pull request as ready for review October 28, 2020 20:20
@mitruska mitruska requested a review from a team October 28, 2020 20:20
@mitruska mitruska self-assigned this Oct 28, 2020
@mitruska mitruska added the category: Core OpenVINO Core (aka ngraph) label Oct 28, 2020
@mitruska mitruska requested review from slyalin and sdurawa October 28, 2020 20:23
@slyalin slyalin requested a review from jane-intel October 29, 2020 07:45
@mitruska mitruska requested a review from tomdol October 29, 2020 08:00
Copy link
Contributor

@slyalin slyalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More attention for dynamic dimensions. Please provide relevant tests with ranges.

@mitruska mitruska requested a review from slyalin October 29, 2020 13:17
@mitruska mitruska removed request for a team November 9, 2020 07:57
@mitruska
Copy link
Contributor Author

mitruska commented Nov 9, 2020

@ilyachur You're right, done.

@mitruska mitruska requested a review from slyalin November 10, 2020 16:26
Copy link
Contributor

@slyalin slyalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve one last part that I've pointed in the comment.

@mitruska mitruska requested a review from slyalin November 12, 2020 10:40
@slyalin slyalin merged commit bda370c into openvinotoolkit:master Nov 13, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
…penvinotoolkit#2866)

To follow MatMul spec update for 1D tensors this PR removes FusedOp decomposition for MatMul without changing current MatMul output shape inference logic (numpy/onnx aligned).
Based on previous PR openvinotoolkit#2212 that follows rather current spec logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants