Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to see credential data. #470

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

davidz25
Copy link
Contributor

@davidz25 davidz25 commented Feb 2, 2024

This adds a new "View" button in the credential information screen. This is achieved by just extracting the data from the MSO.

This adds a new "View" button in the credential information
screen. This is achieved by just extracting the data from the MSO.

Signed-off-by: David Zeuthen <[email protected]>
@davidz25 davidz25 requested a review from sorotokin February 2, 2024 18:29
Copy link
Contributor

@sorotokin sorotokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need to address UI code duplication, but it should be a separate PR.

@davidz25 davidz25 merged commit afab57f into main Feb 2, 2024
5 checks passed
@davidz25 davidz25 deleted the show-credential-details branch February 2, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants