Fix/add token #148
Merged
Fix/add token #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8
requested review from
lukasjhan,
zustkeeper and
berendsliedrecht
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #148 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 23 23
Lines 1983 1983
Branches 284 284
=======================================
Hits 1938 1938
Misses 45 45 ☔ View full report in Codecov by Sentry. |
|
@cre8 I think it includes other parts besides the token modification. |
reverted the changes, now its ready |
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
This reverts commit 391a365. Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
|
@cre8 should this pr merge to main? |
|
I first wanted to push it to next and then to main |
cre8
added a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Mirko Mollik <[email protected]> Co-authored-by: github-actions <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
cre8
added a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Mirko Mollik <[email protected]> Co-authored-by: github-actions <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.