Fix coverage upload #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of `coverage` stores data in the internal `.coverage` file that is not supported^1 by codecov. This results in silently (because we dont use fail option by default) not uploading coverage. This fixes it by runnin `coverage xml` in coverage_report which outputs a compatible file in `coverage.xml` 1: https://docs.codecov.com/docs/supported-report-formats#non-supported-code-coverage-formats
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 8 8
Branches 1 1
=========================================
Hits 8 8 ☔ View full report in Codecov by Sentry. |
benoit74
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
LGTM, this is indeed what I used in offspot/metrics in a commit which I probably forgot to backport here, or maybe I was considering metrtics was in an edge case: offspot/metrics@241ef10 😔
We also realized recently kolibri and youtube weren't uploading coverage
Shouldn't we use the fail option then? (we could revert if upload fails to often, but it shouldn't be the case and it probably never happened in metrics)
|
Yes, I think we should have the fail option in the default ; let me add it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of
coveragestores data in the internal.coveragefile that is not supported^1 by codecov.This results in silently (because we dont use fail option by default) not uploading coverage.
This fixes it by runnin
coverage xmlin coverage_report which outputs a compatible file incoverage.xml1: https://docs.codecov.com/docs/supported-report-formats#non-supported-code-coverage-formats