Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javascript - and other - hints which are failing due to missing helpers #53

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

benoit74
Copy link
Collaborator

Fix #52

  • Use real curriculum-helper package from FCC instead of very limited one which had been reproduced in this repo.
  • Remove the helper methods which have been reproduced in this repo.

@benoit74 benoit74 self-assigned this Jan 13, 2025
@benoit74 benoit74 marked this pull request as ready for review January 13, 2025 15:11
@benoit74 benoit74 requested a review from rgaudin January 13, 2025 15:11
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…elpers

Use real curriculum-helper package from FCC instead of very limited one
which had been reproduced in this repo.

Remove the helper methods which have been reproduced in this repo.
@benoit74 benoit74 merged commit da46887 into main Jan 13, 2025
5 checks passed
@benoit74 benoit74 deleted the fix_failing_hints branch January 13, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many Javascript tests are failing
2 participants