Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup JS code and add header toolbar #73

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Cleanup JS code and add header toolbar #73

merged 9 commits into from
Jan 21, 2025

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jan 20, 2025

Changes:

  • simplify JS code by using a Pinia store to fetch data and store shared state, and share data and events between components
  • add a HeaderBar to display logo + fetch shared data
  • add error info component to nicely display bad issues "everywhere"

@benoit74 benoit74 added this to the 1.3.0 milestone Jan 20, 2025
@benoit74 benoit74 self-assigned this Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.20%. Comparing base (f891b6a) to head (fc833b6).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   44.20%   44.20%           
=======================================
  Files           9        9           
  Lines         328      328           
  Branches       41       41           
=======================================
  Hits          145      145           
  Misses        182      182           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 changed the title Cleanup JS code Cleanup JS code and add header toolbar Jan 20, 2025
@benoit74 benoit74 marked this pull request as ready for review January 20, 2025 16:04
@benoit74 benoit74 requested a review from rgaudin January 20, 2025 16:04
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;
I think it would help a lot if types had docstrings

@benoit74
Copy link
Collaborator Author

Good points, thanks a lot, fixed. Also opened #76 to question having a plugin to validate this documentation.

@benoit74 benoit74 merged commit 6286157 into main Jan 21, 2025
9 checks passed
@benoit74 benoit74 deleted the add_pinia branch January 21, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants