Skip to content

Commit

Permalink
Removes io.zipkin.zipkin2:zipkin from bom (#276)
Browse files Browse the repository at this point in the history
This prevents managing a dependency version we don't strictly require

fixes #274

Signed-off-by: Adrian Cole <[email protected]>
  • Loading branch information
codefromthecrypt authored Feb 12, 2025
1 parent cacf9e9 commit 80676b9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
8 changes: 0 additions & 8 deletions bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@

<properties>
<main.basedir>${project.basedir}/..</main.basedir>
<!-- use the same value in ../pom.xml -->
<!-- NOTE: Do not update to 3.x as that has floor Java 8 -->
<zipkin.version>2.27.1</zipkin.version>
</properties>

<url>https://github.com/openzipkin/zipkin-reporter-java</url>
Expand Down Expand Up @@ -81,11 +78,6 @@

<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.zipkin.zipkin2</groupId>
<artifactId>zipkin</artifactId>
<version>${zipkin.version}</version>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>zipkin-reporter</artifactId>
Expand Down
1 change: 0 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
<errorprone.args />
<errorprone.version>2.30.0</errorprone.version>

<!-- use the same value in bom/pom.xml -->
<!-- NOTE: Do not update to 3.x as that has floor Java 8 -->
<zipkin.version>2.27.1</zipkin.version>

Expand Down

0 comments on commit 80676b9

Please sign in to comment.