Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add orElse on Optional #1021

Merged
merged 3 commits into from
Feb 9, 2021
Merged

add orElse on Optional #1021

merged 3 commits into from
Feb 9, 2021

Conversation

julien-truffaut
Copy link
Member

No description provided.

@julien-truffaut
Copy link
Member Author

fix #1020

@julien-truffaut
Copy link
Member Author

I think I found an example where this would break the law. I will add some doc next week.

@julien-truffaut
Copy link
Member Author

Actually no, the example I had in mind is lawful.

@kenbot @cquiroz would you mind to review this

cquiroz
cquiroz approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@julien-truffaut julien-truffaut merged commit 3219251 into master Feb 9, 2021
@julien-truffaut julien-truffaut mentioned this pull request Feb 24, 2021
Closed
@xuwei-k xuwei-k deleted the orElse branch September 25, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

@kenbot kenbot Awaiting requested review from kenbot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-truffaut @cquiroz