add Focus[X]() and .focus() for Iso/ApplyIso #1098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1064
Use paren
I could make
.focus
work but notFocus[X]
. The problem is thatFocus
uses the trick to partially apply type parameteras a result
Focus[X]
is aMkFocus[X]
not anIso[X, X]
. Adding paren toapply
fixed the ambiguity.Moved syntax
I had to move
.focus()
next to the macro extension.focus(_.foo.bar)
. When both extension methods where in different classes, it confuses the compiler.The main issue is for Scala 2, we need define
.focus()
in the macro module.