Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined version constraint #368

Closed
jasonmccreary opened this issue Jun 13, 2023 · 3 comments
Closed

Undefined version constraint #368

jasonmccreary opened this issue Jun 13, 2023 · 3 comments

Comments

@jasonmccreary
Copy link

  • Testbench Version: 8.5.7
  • Laravel Version: 10.13.2
  • PHP Version: 8.2.4
  • Database Driver & Version: N/A

Description:

While not a "bug", the recent constraints for laravel/framework list <10.15.0. However, this is not a real Laravel version (yet). As such, it breaks parsing and compatibility tests. Simply >=10.13.5 or ^10.13.5 is enough to represent the 10.13.5 requirement as well as future versions. It help me, as well as those that use Shift, if you could drop the upper bound, invalid constraint.

@crynobone
Copy link
Member

Simply >=10.13.5 or ^10.13.5 is enough to represent the 10.13.5 requirement as well as future versions.

This would break when Laravel Framework or Testbench Core API has "minor" breaking changes when using --prefer-lowest etc:

Latest version changed from <10.15.0 to <10.14.0.

@jasonmccreary
Copy link
Author

10.14.0 is non-existent as well. I think the simpler way to write this would be ~10.13.5. But, your call. Thanks anyway. I'll just have Shift set projects to ^8.0 instead of tracking the latest versions.

@crynobone
Copy link
Member

Yes that should work fine. The idea is that if they use stable minimum stability they should get stable releases from develop branch, or use 8.x branch if they use dev minimum stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants