-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes GitHub Action workflow to tests on multiple Laravel versions. #6801
Conversation
What do you mean by the opposite? If we require laravel/framework then the opposite is illuminate/contracts? Could you explain why? |
Because windows build can't properly parse caret You should inspect this build https://github.com/statamic/cms/actions/runs/3146066349/jobs/5114089006 Prefer stable should load the latest stable but it's installing Laravel Framework 9.0.0, which force to install an old version of Testbench but allows latest Testbench Core. |
Wow, thanks. Dries tweeted that today. Did you guys only discover this problem today too? |
i personally have been avoiding caret for years but never found a solid reason to promote it for GitHub Actions until now. Due to the current issue, I submitted few PR to Laravel packages to avoid using caret and Dries pinpoint the root cause. TIL too (was previously assumed Composer on Windows has a gotcha). |
I see why you are requiring illuminate/contracts instead of framework. It allows the framework constraint in composer.json to control the lowest version. That's something I struggled with, and why I had those extra Very clever trick. Thank you! It would be awesome if this was explained on the testbench docs. I'm sure other people would find it useful to know the best way to test their packages across multiple versions/OSs on GitHub actions. |
Here's some tips about testing multiple versions:
laravel/framework
or one of theilluminate/*
component torequire
section (already done).require-dev
. If you require the framework you should install one of the components using7.x
,8.x
or9.x
constraint, or the opposite.